Skip to content

[VID-1603] Document should_retry as RPC-only #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoppi merged 2 commits into from
Oct 14, 2026
Merged

[VID-1603] Document should_retry as RPC-only #2146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1234eb
[VID-1603] Document should_retry as RPC-only
atoppi Oct 14, 2026
262b9bd
Merge branch 'main' into atoppi/vid-1603-should-retry-rpc-only
atoppi Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions protobuf/video/sfu/event/events.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions protobuf/video/sfu/event/events.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ message PinsChanged {
}

message Error {
// error.should_retry is not set on this event; follow reconnect_strategy.
models.Error error = 4;
// returns the reconnect strategy to be used by the client
models.WebsocketReconnectStrategy reconnect_strategy = 5;
Expand Down
10 changes: 7 additions & 3 deletions protobuf/video/sfu/models/models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions protobuf/video/sfu/models/models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,10 @@ enum ErrorCode {
message Error {
ErrorCode code = 1;
string message = 2;
// Only meaningful in RPC responses: true means the client may retry the same
// request. On a websocket error event (stream.video.sfu.event.Error) the SFU
// never sets it and clients must ignore it: reconnect_strategy decides what
// the client does.
bool should_retry = 3;
}

Expand Down
Loading