Repository navigation
Fixes output of x_period and y_period - #279
Merged
Merged
Conversation
For periodic grids, x and y_period where being read in as character strings and then converted to doubles for output in the mesh. The read in as a string caused only the first two decimals to be read of y_period and x_period, which breaks periodicity in MPAS. This commit reads in x_period and y_period as doubles and skips the conversions.
Contributor
Author
|
I've confirmed this fix restores doubly periodic behavior for my COMPASS test case. I can show before and after if you'd like |
xylar
approved these changes
Jan 22, 2020
xylar
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this, @vanroekel. Some odd code here...
Collaborator
|
@vanroekel, do you want a new release of the mpas-tools package as soon as this goes in? That would allow us to update the COMPASS environments but would still take awhile to make its way to E3SM-Unified. |
Contributor
Author
|
@xylar having a new release of the compass environment would be much appreciated. |
Collaborator
|
@pwolfram, can you review this as soon as you're able so I can get this in? |
pwolfram
approved these changes
Jan 23, 2020
pwolfram
left a comment
Contributor
There was a problem hiding this comment.
Reviewed by visual inspection, much cleaner solution @vanroekel!
Contributor
|
@xylar, thanks for your patience-- it's all good to go! |
xylar
added a commit
to xylar/MPAS-Tools
that referenced
this pull request
Mar 5, 2020
MPAS-Dev#279 fixed y_period but other attributes were still being read as strings and converted to doubles (even though they are stored in the NetCDF file as doubles). The remaining variables need to be fixed in the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For periodic grids, x and y_period where being read in as character
strings and then converted to doubles for output in the mesh. The read
in as a string caused only the first two decimals to be read of y_period
and x_period, which breaks periodicity in MPAS.
This commit reads in x_period and y_period as doubles and skips the
conversions.