Repository navigation
Fix reading of sphere_radius, x_period and mesh_spec - #296
Merged
Merged
Conversation
MPAS-Dev#279 fixed y_period but other attributes were still being read as strings and converted to doubles (even though they are stored in the NetCDF file as doubles). The remaining variables need to be fixed in the same way.
Collaborator
Author
TestingI build the conda package with this source. With the new build, I ran: This is the expected value. Thanks for the help identifying the problem @jonbob! |
Collaborator
Author
|
@vanroekel and @jonbob, if you could glance at the changes and make sure:
There are also some white-space changes that happen automatically in my editor, so don't worry about those. I also updated the version number because this fix is worthy of a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#279 fixed y_period but other attributes were still being read as strings and converted to doubles (even though they are stored in the NetCDF file as doubles). The remaining variables need to be fixed in the same way.