Skip to content

Vaults general fixes and QOL #340

Closed
#266
Closed
Vaults general fixes and QOL#340
#266
Assignees
tegefaulkes
Labels
developmentStandard developmentr&d:polykey:core activity 1Secret Vault Sharing and Secret History Management

Description

@tegefaulkes
tegefaulkes
opened on Feb 15, 2022

Specification

This issue relates to general fixes and QOL changes.
Change to selective imports in all relevant domains. And ensure there are no import cycles in the vaults domain.

     ┌──────────────────┐
     │                  │
     │                  │
Errors────►Types ──┐    │
  │         │      │    │
  │         │      │    │
  ▼         │      │    │
Utils ◄─────┘      │    │
  │                ▼    │
  └─────────► Classes ◄─┘

Additional context

Tasks

  1. switch Vaults domain to using selective imports.
  2. switch vaults tests to using selective imports.
  3. Vaults domain errors need to be reviewed and updated with proper descriptions and sysexit codes.
  4. VaultId decoding needs to be checked for if fromMultibase throws an error. this needs to be fixed.
  5. VaultsLog GRPC method can use the google timestamp type for the timestamp.

Activity

  1. tegefaulkes
    added
    developmentStandard development
    on Feb 15, 2022
  2. tegefaulkes
    changed the title [-]Switching to selective imports in vaults domain[/-] [+]Vaults general fixes and QOL[/+] on Feb 16, 2022

  3. CMCDragonkai commented on Feb 16, 2022

    @CMCDragonkai
    CMCDragonkai
    on Feb 16, 2022
    Member

    It would be similar to:

      protected connections: Map<NodeIdString, ConnectionAndLock> = new Map();

    So yea vault map (the in-memory one) would use VaultIdString.

  4. tegefaulkes
    added a commit that references this issue on Feb 21, 2022

    WIP - #340 - selective imports

    acdb772

  5. tegefaulkes commented on Feb 21, 2022

    @tegefaulkes
    tegefaulkes
    on Feb 21, 2022
    ContributorAuthor

    decodeVaultId still throws errors in some circumstances. I've made a comment on the PR related to this at MatrixAI/js-id#14 (comment).

  6. tegefaulkes
    added 2 commits that reference this issue on Feb 21, 2022

    WIP - #340 - error descriptions updated

    4724a7f

    WIP - #340 - Using google `Timestamp` message in `LogEntry` message

    c43cc80

  7. tegefaulkes commented on Feb 22, 2022

    @tegefaulkes
    tegefaulkes
    on Feb 22, 2022
    ContributorAuthor

    VaultId decoding needs to be checked for if fromMultibase throws an error. this needs to be fixed. will be fixed after MatrixAI/js-id#15 is merged and the js-id version is updated here.

  8. tegefaulkes
    added 2 commits that reference this issue on Feb 22, 2022

    Fixes #340

    cf2700b

    Fixes #340

    c504972
  9. tegefaulkes
    added 5 commits that reference this issue on Mar 9, 2022

    WIP - #340 general clean up

    f652b0d

    WIP - #340 fixing imports

    7580cff

    WIP - #340 fixing comments

    353be7a

    WIP - #340 updating errors

    1d55287

    Fixes #340

    96c752e
  10. tegefaulkes
    closed this as completedin #266on Mar 9, 2022
  11. teebirdy
    added
    r&d:polykey:core activity 1Secret Vault Sharing and Secret History Management
    on Jul 24, 2022
  12. CMCDragonkai
    assigned
    tegefaulkes
    on Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

developmentStandard developmentr&d:polykey:core activity 1Secret Vault Sharing and Secret History Management

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions