[emmacasolin]

Description

The fromMultibase() utility was throwing a Syntax Error on plain string inputs, when it should instead have been returning undefined. The line this was coming from, codec.decode(), has now been warpped in a try-catch block in order to return undefined on this error, as is the expected behaviour.

Tasks

1. Add a catch handler on codec.decode() for Syntax Errors
2. Update utils tests to cover this case

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[tegefaulkes]

This is still broken. Here is an example of a failing test.

  test('fromMultibase is throwing an error', async () => {
    expect(IdInternal.fromMultibase('zF4VfF3uRhSqgxTOOLONGxTRdVKauV9')).toBeUndefined();
    expect(IdInternal.fromMultibase('zFxTOOSHORTx9')).toBeUndefined();
  })

I think the problem is that it's throwing just a normal Error() with the message Non-base58btc character so it's not getting caught by the catch block and returning undefined.

Problem is that any base is valid for decoding and each one will have it's own error message. we may have to catch all errors here and return with undefined.

@CMCDragonkai , @emmacasolin

[CMCDragonkai]

Could have sworn it was SyntaxError.

Can you confirm if it is actually throwing Error?

[CMCDragonkai]

Ok I checked, yea it does do this.

Well then we just need to change it to:

} catch (e) {
  return;
}

[CMCDragonkai]

@emmacasolin can you clean this up.

[emmacasolin]

Fix is on the same branch but in a different PR here: #15