Skip to content

Barrier -> ParticleBarrier #275

Closed
Closed

Description

@kashike

This class is missing the Particle prefix:
net.minecraft.client.particle.Barrier -> net.minecraft.client.particle.ParticleBarrier

Activity

  1. williewillus commented on Nov 15, 2016

    @williewillus
    Contributor

    +1, all the other particle classes have Particle in front except this one

  2. shadowfacts commented on Nov 15, 2016

    @shadowfacts

    Agreed, the barrier particle should follow the same conventions as everything else.

  3. modified the milestone: 1.12.0 on Nov 16, 2016
  4. LexManos commented on Jun 8, 2017

    @LexManos
    Member

    Its a slow unimportant process, I want to move away from Smurf naming.
    Maybe if someone gathers up the de-smurfs for 1.13 i'll rename them all.

  5. Pokechu22 commented on Jun 8, 2017

    @Pokechu22

    For reference, smurf naming is defined here (I didn't recognize the term).

    I don't know if it is possible to move away from smurf naming - there have been problems with multiple classes of the same name (see, for instance, #373), so if, as an example, net.minecraft.block.BlockFurnace, net.minecraft.client.gui.inventory.GuiFurnace, net.minecraft.inventory.ContainerFurnace, and net.minecraft.tileentity.TileEntityFurnace were all renamed to get rid of the prefix (net.minecraft.block.Furnace, net.minecraft.client.gui.inventory.Furnace, net.minecraft.inventory.Furnace, and net.minecraft.tileentity.Furnace) there may be issues.

  6. williewillus commented on Jun 8, 2017

    @williewillus
    Contributor

    yeah, I think it needs to be retained to some degree to disambiguate block vs te vs particle, etc.
    Enums are really the only things that can do with eliminating their prefix, since they are likely not to clash with anything else. Maybe Items as well

  7. kashike commented on Jun 8, 2017

    @kashike
    CollaboratorAuthor

    Entities can pretty much be renamed without issue (Player, Sheep, Cow, etc) as well.

  8. modified the milestones: 1.12.0, 1.13.0 on Sep 18, 2017
  9. modified the milestones: 1.13.0, 1.14.0 on Sep 5, 2018
  10. LexManos commented on Dec 10, 2019

    @LexManos
    Member

    Already named net/minecraft/client/particle/BarrierParticle in the bulk rename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions