Skip to content

Source Code page and references to script/lib #150

Closed

Description

@supahgreg

The "Source Code" page does not have the script page header, making identification and navigation trickier than it should be. As a user I'd like the Source Code page to share the layout of other script- or lib-related pages.

Activity

  1. sizzlemctwizzle commented on Jun 13, 2014

    @sizzlemctwizzle
    Member

    +1 for putting the script page header on the source code page

    Edit: Also, nice to see a Scriptish dev here. Welcome aboard.

  2. jerone commented on Jun 13, 2014

    @jerone
    Contributor

    I tried to fix this issue (noticed this too), but I have to completely rewrite the whole function user>editScript.

    I'm thinking of separting the 'view source' and 'edit source' logic. Any reasons why this has been combined without any addition info like in script>view function?

  3. Zren commented on Jun 15, 2014

    @Zren
    Contributor

    I'm thinking of separating the 'view source' and 'edit source' logic. Any reasons why this has been combined without any addition info like in script>view function?

    Nope. It's currently used as the scriptViewSourcePage, scriptEditSourcePage, and userWriteNewScriptPage.

    scriptViewSourcePage/scriptEditSourcePage could possibly share a template, or they could share includes. userWriteNewScriptPage shouldn't have the script header though, so it needs it's own template.

  4. Martii commented on Jun 15, 2014

    @Martii
    Member

    @jerone first and @Zren second,
    Would you scoot any of your above relevant comments over to #169 please... this should be better to isolate the issues so they can be worked on independently and one step at time... we are live remember. Occasionally we will have ideas at nearly the same time and best to keep them historically tracked as cleanly as possible. Thanks. :)


    +1 for putting the script page header on the source code page

    Specific to this issue topic +1 here.

  5. Martii commented on Jul 9, 2014

    @Martii
    Member

    completely rewrite the whole function user>editScript.

    In regards to this just noticed the current route is marked as Legacy and to be removed in app.js from ec278a9 which is a little odd to put that in on a commit to be removed later. If the code is just going to be dumped there isn't much of a point to keep this on non-later status... labeling as later.

  6. 3 remaining items

  7. Martii commented on Oct 23, 2014

    @Martii
    Member

    Btw @Zren you've been hung on this for a while which is why I am offering this up.

  8. added
    hungNot what you are thinking. Unable to resolve after assignment.
    on Oct 23, 2014
  9. self-assigned this
    on Oct 23, 2014
  10. Martii commented on Oct 23, 2014

    @Martii
    Member

    Closed by #387

  11. removed their assignment
    on Oct 23, 2014
  12. added a commit that references this issue on Nov 3, 2014
  13. removed
    hungNot what you are thinking. Unable to resolve after assignment.
    on Nov 3, 2014
  14. locked as resolved and limited conversation to collaborators on Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugYou've guessed it... this means a bug is reported.enhancementSomething we do have implemented already but needs improvement upon to the best of knowledge.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions