Skip to content

Issue 150script source page header - #387

Merged
Martii merged 5 commits into
OpenUserJS:masterfrom
Martii:Issue-150scriptSourcePageHeader
Oct 23, 2014
Merged

Martii merged 5 commits into
OpenUserJS:masterfrom
Martii:Issue-150scriptSourcePageHeader

Conversation

@Martii

@Martii Martii commented Oct 23, 2014

Copy link
Copy Markdown
Member

Piecemealed from script.js... not perfect I would assume but it's a start after several months. Please open a new issue ticket if there is any new issue detected.

Martii added 5 commits October 22, 2014 23:26
* Works on dev
* There is probably some redundant, unused, mustache options set since this is merged/modified code from `script.js` e.g. not efficient at the moment.
* Breadcrumbs are slightly off position wise due to the sidebar being absent

Perhaps the fix needed for OpenUserJS#150. This is my least familiar portion of the code but trying to learn it now... hopefully with the help of some others. :)
* Obviously not optimized with external CSS here but so is the rule before it.

Applies to OpenUserJS#150
* Again mirrored from script.js with a modification to work in this controller.
* Remove TODO for this item

Applies to OpenUserJS#150
Martii added a commit that referenced this pull request Oct 23, 2014
Issue 150script source page header

Auto-merged
@Martii
Martii merged commit 0c8a3d8 into OpenUserJS:master Oct 23, 2014
@Martii
Martii deleted the Issue-150scriptSourcePageHeader branch October 23, 2014 07:26
@Martii Martii added UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Nov 3, 2014
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. UI Pertains inclusively to the User Interface.

Development

Successfully merging this pull request may close these issues.

2 participants