Skip to content

fix: scope maintainer skill identity to the owning package - #313

Merged
LadyBluenotes merged 2 commits into
mainfrom
fix/maintainer-package-scoped-identity
Oct 4, 2026
Merged

LadyBluenotes merged 2 commits into
mainfrom
fix/maintainer-package-scoped-identity

Conversation

@LadyBluenotes

@LadyBluenotes LadyBluenotes commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

intent maintainer treated a skill name as unique across the whole repository. In a monorepo where two packages each register a skill with the same name, every maintainer command stopped with Duplicate skill identity or path. TanStack Table has getting-started, table-state, and migrate-v8-to-v9 in several adapter packages, so maintainer status, check, and sync could not run there.

A skill name is now unique within its owning package.

  • Tree entries. Two entries in different packages can share a name. Two entries in the same package with the same name, or any two entries with the same path, are still rejected.
  • maintainer add. The same name can be registered in a second package.
  • Prerequisites. A bare name in requires refers to a skill in the same package. A skill in another package is named as <package>#<skill>. A bare name that only exists in another package is now reported by sync and check.
  • maintainer remove <name>. Accepts --package <directory>. When more than one package registers the name and no package is given, the command lists the packages.
  • Repository distribution. A name that more than one package registers cannot be selected, because installers address skills by name only. The error lists the packages.
  • Domain map. When domain_map.yaml has several entries with the same slug, sync compares a skill with the entry in its own domain.
  • maintainer setup. Existing skills with the same name in different packages are both registered. Two unregistered skills with the same name in one package are still skipped.

@changeset-bot

changeset-bot Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e1dc69d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/intent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8b1c6629-af07-42fe-a110-e96800219ddb
📥 Commits

Reviewing files that changed from the base of the PR and between c16a6a8 and e1dc69d.

📒 Files selected for processing (10)
  • .changeset/maintainer-package-scoped-identity.md
  • docs/cli/intent-maintainer.md
  • packages/intent/src/commands/maintainer.ts
  • packages/intent/src/maintainer/add.ts
  • packages/intent/src/maintainer/distribution.ts
  • packages/intent/src/maintainer/existing.ts
  • packages/intent/src/maintainer/project.ts
  • packages/intent/src/maintainer/remove.ts
  • packages/intent/src/maintainer/sync.ts
  • packages/intent/tests/maintainer.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit e5fb2ee

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 1m 2s View ↗
nx run-many --targets=build ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-04 17:31:19 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@313

commit: e1dc69d

@codspeed

codspeed Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fix/maintainer-package-scoped-identity (e1dc69d) with main (c16a6a8)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes added this pull request to stack #320 October 4, 2026 17:57
@LadyBluenotes
LadyBluenotes merged commit 39d2af8 into main Oct 4, 2026
10 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix/maintainer-package-scoped-identity branch October 4, 2026 17:57
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant