Skip to content

fix: rewrite tree paths that repeat the package directory in maintainer sync - #317

Merged
LadyBluenotes merged 1 commit into
mainfrom
fix/maintainer-sync-repeated-package-path
Oct 4, 2026
Merged

LadyBluenotes merged 1 commit into
mainfrom
fix/maintainer-sync-repeated-package-path

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

🎯 Changes

Stacked on #313.

A skill_tree.yaml entry locates its skill with package and a path relative to that package. A hand-written tree can repeat the package directory in path:

package: packages/react-table
path: packages/react-table/skills/table-state/SKILL.md

intent maintainer joined the two values, looked for packages/react-table/packages/react-table/skills/table-state/SKILL.md, and reported Missing skill although the file existed. TanStack Table's tree uses this form, so maintainer status counted 0 of its 39 skills.

maintainer sync now recognizes this form when the file exists at path and not at the joined location:

  • maintainer status and maintainer check find the skill and list skill_tree.yaml as a file to synchronize.
  • maintainer sync rewrites the entry as path: skills/table-state/SKILL.md.

A path that is wrong for any other reason still reports Missing skill.

On TanStack Table, maintainer status goes from 0 skill(s) with 39 Missing skill lines to 39 skill(s), 1 file(s) to sync, and maintainer sync rewrites the 39 paths.

@changeset-bot

changeset-bot Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e728066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/intent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5bee14d9-0620-486a-bbaa-51d225c834db
📥 Commits

Reviewing files that changed from the base of the PR and between 39d2af8 and e728066.

📒 Files selected for processing (4)
  • .changeset/maintainer-sync-repeated-package-path.md
  • docs/cli/intent-maintainer.md
  • packages/intent/src/maintainer/sync.ts
  • packages/intent/tests/maintainer.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit a87291d

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 1m 4s View ↗
nx run-many --targets=build ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-04 17:59:13 UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@317

commit: e728066

@codspeed

codspeed Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing fix/maintainer-sync-repeated-package-path (e728066) with main (39d2af8)

Open in CodSpeed

@LadyBluenotes
LadyBluenotes added this pull request to stack #320 October 4, 2026 17:57
Base automatically changed from fix/maintainer-package-scoped-identity to main October 4, 2026 17:57
@LadyBluenotes
LadyBluenotes force-pushed the fix/maintainer-sync-repeated-package-path branch from a87291d to e728066 Compare October 4, 2026 17:57
@LadyBluenotes
LadyBluenotes merged commit 894ab61 into main Oct 4, 2026
9 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix/maintainer-sync-repeated-package-path branch October 4, 2026 18:02
@github-actions github-actions Bot mentioned this pull request Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant