Error in `filter-clues` Plugin

[AyanSinhaMahapatra]

Description

Running the following Command:

./scancode -clp --json-pp sample_filter_clues.json samples --filter-clues

Gives the Error:

ERROR: failed to run post-scan plugin: filter-clues:
Traceback (most recent call last):
  File "/home/ayansm/Desktop/GSoD/scancode-toolkit-versions/scancode-toolkit-3.1.1/src/scancode/cli.py", line 1033, in run_codebase_plugins
    plugin.process_codebase(codebase, **kwargs)
  File "/home/ayansm/Desktop/GSoD/scancode-toolkit-versions/scancode-toolkit-3.1.1/src/cluecode/plugin_filter_clues.py", line 90, in process_codebase
    filtered = filter_ignorable_resource_clues(resource, rules_by_id)
  File "/home/ayansm/Desktop/GSoD/scancode-toolkit-versions/scancode-toolkit-3.1.1/src/cluecode/plugin_filter_clues.py", line 105, in filter_ignorable_resource_clues
    resource.emails = filtered.emails
AttributeError: 'ScannedResource' object has no attribute 'emails'

Scanning done.
Some files failed to scan properly:
ERROR: failed to run post-scan plugin: filter-clues:
Traceback (most recent call last):
  File "/home/ayansm/Desktop/GSoD/scancode-toolkit-versions/scancode-toolkit-3.1.1/src/scancode/cli.py", line 1033, in run_codebase_plugins
    plugin.process_codebase(codebase, **kwargs)
  File "/home/ayansm/Desktop/GSoD/scancode-toolkit-versions/scancode-toolkit-3.1.1/src/cluecode/plugin_filter_clues.py", line 90, in process_codebase
    filtered = filter_ignorable_resource_clues(resource, rules_by_id)
  File "/home/ayansm/Desktop/GSoD/scancode-toolkit-versions/scancode-toolkit-3.1.1/src/cluecode/plugin_filter_clues.py", line 105, in filter_ignorable_resource_clues
    resource.emails = filtered.emails
AttributeError: 'ScannedResource' object has no attribute 'emails'

System configuration

For bug reports, it really helps us to know:

• What OS are you running on? Ubuntu 16.04 LTS
• What version of scancode-toolkit was used to generate the scan file? v3.1.1
• What installation method was used to install/run scancode? Source Download

[pombredanne]

@AyanSinhaMahapatra Thanks! can you tell if this also happens in the develop branch latest and greatest?

[AyanSinhaMahapatra]

@pombredanne Sorry for the delay. Yes, the same error occurs in the develop branch latest.

[pombredanne]

Thanks, I am making this as a must have for the next release candidate!

[Iamshankhadeep]

@pombredanne Can I work on it?

[pombredanne]

@Iamshankhadeep please go for it!

[Iamshankhadeep]

@pombredanne how can I solve this? I am not getting any Ideas.

[Iamshankhadeep]

@pombredanne can you give me any idea about how to solve it?

[pombredanne]

@Iamshankhadeep here are steps:

1. try to reproduce the problem in the most minimal way with a command line invocation of scancode as outlined above, trying to find a few files that make this fail
2. once you have a minimally reproducible problem, create a unit test (that is failing for now) that reproduces the problem. Assert the things that should be there in the results.
3. look at the failure trace and try to understand why this is not working and which places the code may need fixing.

I can start to help you more easily with 3. once you have done 1. and 2. :)