Fix bug in filter-clues plugin

[tushar912]

Fixes #1758

Tasks

• Reviewed contribution guidelines
• PR is descriptively titled 📑 and links the original issue above 🔗
• Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  Run tests locally to check for errors.
• Commits are in uniquely-named feature branch and has no merge conflicts 📁

[AyanSinhaMahapatra]

A nitpick, keep only one new line between methods and two new lines between functions and classes.

[AyanSinhaMahapatra]

@tushar912 Does ./scancode -clpieu --json-pp sample_filter_clues.json samples --filter-clues run properly now? Could you post the output JSON here?

The 2 failing tests seem to be from other problems that are fixed in the release branch.

[AyanSinhaMahapatra]

Also, could you change the commit message according to this doc - https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

So,

1. Add more context about what is changed in the commit body,
2. change fixes to fix in both PR name and commit header. https://chris.beams.io/posts/git-commit/#imperative
   etc.

[tushar912]

@AyanSinhaMahapatra I think it is working I am getting this json output

filter_clues_bugfix_sample.json.txt

[pombredanne]

@tushar912 @AyanSinhaMahapatra what's left to do here? I would like to merge this ASAP :)

[AyanSinhaMahapatra]

@pombredanne I've tested this branch locally, the bug isn't there anymore, the test reproducing the earlier bug passes (the test fails are from other problems fixed in the release branch), and the plugin seems to be doing everything as it should, i.e. removing redundant duplicated clues already contained in detected license and copyright texts and notices. It seems ready to merge to me, but you should still check the changes to see everything is in place.

But the commit message has to be changed as it seems to have leftovers from squashing two commits together, having two bodies, and two signoffs. @tushar912

[tushar912]

@AyanSinhaMahapatra I have changed the commit message .I think it looks better now.

[AyanSinhaMahapatra]

Another nitpick, adding the issue number on the commit header/body would be best. Just add #1758 after bug in the header and that would be all. Sorry I missed this before. Thanks++

[tushar912]

@AyanSinhaMahapatra I have made the change.

[pombredanne]

LGTM! Thank you++

[pombredanne]

@AyanSinhaMahapatra please go ahead and merge

[pombredanne]

@tushar912 Thank you ++ 🙇