Add new copyright test cases

[pombredanne]

See https://github.com/oss-review-toolkit/ort/blob/9493dab0cad7e102509a4a061e7bb87dd69ef598/utils/src/test/assets/copyright-statements-expected-output.yml

These are potentially incorrect copyright detection in ScanCode Toolkit.

First is to understand how the copyright tests work by carefully reading and trying to follow execution of https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/test_copyrights.py

We generate test method at import time that are attached to a test class (See https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/cluecode_test_utils.py for the generation code) and in particular see https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/cluecode_test_utils.py#L55 for details on how test files are organized: a file to test for copyrights and a YAML file with expected results such as here: https://github.com/nexB/scancode-toolkit/tree/develop/tests/cluecode/data/copyrights

So the approach would likely be to generate these tests file pairs such as these:

• https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/data/copyrights/adobe_license.txt.yml
• https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/data/copyrights/adobe_license.txt

You can run the test suite with pytest -vvs --test-suite=all tests/cluecode/

[mk1107]

Hello @pombredanne , I wish to take a try at this issue. Could you please assign it to me? Also, it is my first issue with the toolkit so I would need some guidance over as to what exactly needs to be done in the issue.
Thanks!

[pombredanne]

Thank! I look forward to your kind help. First is to understand how the copyright tests work by carefully reading and trying to follow execution of https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/test_copyrights.py

We generate test method at import time that are attached to a test class (See https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/cluecode_test_utils.py for the generation code) and in particular see https://github.com/nexB/scancode-toolkit/blob/develop/tests/cluecode/cluecode_test_utils.py#L55 for details on how test files are organized: a file to test for copyrights and a YAML file with expected results such as here: https://github.com/nexB/scancode-toolkit/tree/develop/tests/cluecode/data/copyrights

So the approach would likely be to generate these tests file pairs

[mk1107]

Ok thanks for guidance @pombredanne . I will go through all this things, and then discuss things with you.

[mk1107]

sorry for delay from my side. But can you further guide me, i went through all the given links, but unable to understand what i need to do? So, if possible can u further guide me.

[pombredanne]

@mk1107 can you may be ask for some help and guidance to the community at https://gitter.im/aboutcode-org/discuss ?

[NinaPacifier]

Hey, @pombredanne May I work on this issue??

[tushar912]

@pombredanne can I work on this

[sritasngh]

Anyone working on this issue? I would like to work :)

[abhishak3]

@pombredanne i added new copyright test cases.