Fix copyright detection for text-classified files and restore fixtures(#2299) - #5264
Merged
AyanSinhaMahapatra merged 1 commit intoAug 28, 2026
Conversation
This fixes a regression in numbered_text_lines() where valid text-bearing files were dropped when typecode reported contains_text == False, even though they were still text-classified and extractable. The early return prevented cluecode from detecting copyright notices in files misidentified by libmagic. We now allow text-classified files through the normal extraction path instead of rejecting them prematurely. This also restores corrupted ORT and junk-copyright fixture inputs that were causing false failures in the cluecode golden tests. Signed-off-by: Bo Liu <bo2018luo@gmail.com>
BoLiuV5
force-pushed
the
boliuv5-add-copyright-test-cases-2299
branch
from
August 12, 2026 17:30
a3dbeb1 to
204292e
Compare
AyanSinhaMahapatra
approved these changes
Aug 28, 2026
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks @BoLiuV5 LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in
numbered_text_lines()where valid text-bearing files were dropped whentypecodereportedcontains_text == False, even though they were still text-classified and extractable.The early return prevented cluecode from detecting copyright notices in files misidentified by libmagic. We now allow text-classified files through the normal extraction path instead of rejecting them prematurely.
This also restores corrupted ORT and junk-copyright fixture inputs that were causing false failures in the cluecode golden tests.
Fixes #2299
Tasks