Update package scan for package.json file - #2457
Merged
Merged
Conversation
Signed-off-by: Divyansh2512 <2512sharmadivyansh@gmail.com>
Signed-off-by: Divyansh2512 <2512sharmadivyansh@gmail.com>
Signed-off-by: Divyansh2512 <2512sharmadivyansh@gmail.com>
Signed-off-by: Divyansh2512 <2512sharmadivyansh@gmail.com>
Contributor
Author
|
@MaJuRG @pombredanne Kindly review! |
steven-esser
approved these changes
Mar 25, 2021
steven-esser
left a comment
Contributor
There was a problem hiding this comment.
@Divyansh2512 Thanks for this!
@pombredanne anything else to add here?
rpotter12
approved these changes
Mar 25, 2021
pombredanne
approved these changes
Mar 26, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Looking great! I have a nitpicking comment but that's not in the way of merging.
| try: | ||
| npm.parse(test_file) | ||
| except AttributeError as e: | ||
| assert "'NoneType' object has no attribute 'to_dict'" in str(e) |
Member
There was a problem hiding this comment.
I guess there be a better exception raises, like a new one such as a NpmWithoutNameError ?
But we can merge this as is for now. An update later is welcomed!
Member
|
@rpotter12 @MaJuRG thanks for the review too BTW 🙇 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2382
Checks for existance of name constraint only instead of both name and version.
Tasks
Run tests locally to check for errors.