add new tests for pypi setup.py - #2465
Siddhant-K-code wants to merge 1 commit into
Conversation
Signed-off-by: Siddhant Khare <siddhantkhare2694@gmail.com>
ac08081 to
a99b671
Compare
|
@MaJuRG @pombredanne Please Review! |
steven-esser
left a comment
There was a problem hiding this comment.
@Siddhant-K-code What is the related issue these tests are for?
The issue is currently not there, but it can create a mess/issue if a |
pombredanne
left a comment
There was a problem hiding this comment.
Thanks!
Do you know if if is possible to even get a working setup.py without a version or without a name?
yes, it is a good practice to do so? |
It is probably a bad practice, but we have to deal with it! It create an "UNKNOWN" name. |
|
Do you mind to rebase on the latest and we can then find a proper way to handle this case? |
| except AttributeError as e: | ||
| assert "'NoneType' object has no attribute 'to_dict'" in str(e) |
There was a problem hiding this comment.
I would probably be nicer to have a named exception for this or some custom logged error message so we know what exactly is wrong with the setup.py pypi package (in this case, a missing name field).
Improve tests and ensure we can handle nameless PyPI packages. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Improve tests and ensure we can handle nameless PyPI packages. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Description lines are sometimes padded with 8 spaces. When this happen these need to be trimmed and this was not taking place correctly Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
This has been merged with accd630 after a rebase. Thank you ++ |
Fixes:
Added New Tests for pypi setup.py
Tasks
Run tests locally to check for errors.