Follow license reference to another file - #2616
Merged
Merged
Conversation
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
Contributor
Author
|
Hey! @AyanSinhaMahapatra How we will go about adding same logic for packagecode like we discussed yesterday? |
AyanSinhaMahapatra
requested changes
Aug 4, 2021
Member
|
Also, for packagedcode, say for npm, see here. We have a function converting a list of license declarations to a license-expression. It would have been ideal if we return some form of License Detections here instead of just the expressions (which is WIP), but in a short term we could check first for these kind of license references to file (and report only the license conclusion without the unknown). |
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
akugarg
force-pushed
the
follow_reference
branch
from
August 7, 2021 09:05
29ddb8a to
4aab0aa
Compare
This was referenced Aug 9, 2021
akugarg
force-pushed
the
follow_reference
branch
from
August 13, 2021 18:14
2ba8f14 to
4559aab
Compare
akugarg
force-pushed
the
follow_reference
branch
2 times, most recently
from
August 14, 2021 09:09
3200da4 to
d4f1436
Compare
Contributor
Author
|
@AyanSinhaMahapatra @pombredanne Please have a look! |
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
requested changes
Aug 15, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! beside the review comments, I would also like to see some unit tests for find_reference_licenses
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
pombredanne
reviewed
Aug 15, 2021
akugarg
force-pushed
the
follow_reference
branch
2 times, most recently
from
August 15, 2021 11:44
d478c25 to
10385da
Compare
akugarg
force-pushed
the
follow_reference
branch
from
August 16, 2021 11:02
10385da to
27146ae
Compare
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
akugarg
force-pushed
the
follow_reference
branch
from
August 17, 2021 12:30
27146ae to
a84b1ed
Compare
pombredanne
requested changes
Aug 25, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
I have a few final review items for you. Thanks!
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
akugarg
force-pushed
the
follow_reference
branch
from
August 26, 2021 15:35
b8544b1 to
466e375
Compare
pombredanne
reviewed
Aug 27, 2021
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
4 tasks
pombredanne
added a commit
that referenced
this pull request
Aug 29, 2021
Only follow license references match an exact filename In #2616 we introduced matching path of referenced_filenames based on matching filename or path suffix. This removes path suffix matching which is problematic. Before this we were using .endswith(path) and this led to weird and incorrect license dereferences Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: akugarg akanksha.garg2k@gmail.com
Fixes #1364
Tasks
Run tests locally to check for errors.