Referenced_filenames should be returned by API function - #2632
Merged
Conversation
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
akugarg
force-pushed
the
update_api
branch
8 times, most recently
from
August 11, 2021 13:42
8977b09 to
3bbaf27
Compare
Contributor
Author
|
@AyanSinhaMahapatra All green! |
AyanSinhaMahapatra
approved these changes
Aug 11, 2021
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks ready.
Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
pombredanne
approved these changes
Aug 12, 2021
pombredanne
left a comment
Member
There was a problem hiding this comment.
Perfect!
LGTM.... Please also add a CHANGELOG.rst entry for this and the feature of follwing these references (this can be in another PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: akugarg akanksha.garg2k@gmail.com
Check #2616 (comment) for more details
Tasks
Run tests locally to check for errors.