Fix #3250: Invalid SPDX with empty file: no SHA1 - #3279
Merged
AyanSinhaMahapatra merged 2 commits intoMar 28, 2023
Conversation
Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
pombredanne
requested changes
Feb 27, 2023
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! let's add a test to avoid any regression.
Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
Contributor
Author
|
I have added a test that is successful is However, some tests fails that seem unrelated. Can you please check? |
AyanSinhaMahapatra
approved these changes
Mar 20, 2023
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
@vargenau LGTM! Thanks!
The test failures seem to be a heisenbug and happens in other PRs too sometimes, nothing related to this change ofc.
Member
|
@vargenau Thanks, merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3250
Tasks
Run tests locally to check for errors.
Signed-off-by: Marc-Etienne Vargenau marc-etienne.vargenau@nokia.com