Skip to content

Fix #3250: Invalid SPDX with empty file: no SHA1 #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AyanSinhaMahapatra merged 2 commits into from
Mar 28, 2023
Merged

Fix #3250: Invalid SPDX with empty file: no SHA1 #3279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0af1d3
Fix #3250: Invalid SPDX with empty file: no SHA1
vargenau Feb 27, 2023
d7e8318
Add test test_output_spdx_tv_sh1_of_empty_file
vargenau Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/formattedcode/output_spdx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,10 @@ def write_spdx(
file_entry = File(
spdx_id=f'SPDXRef-{sid}',
name=name)
file_entry.set_checksum(Checksum(ChecksumAlgorithm.SHA1, file_data.get('sha1') or ''))
if file_data.get('file_type') == 'empty':
file_entry.set_checksum(Checksum(ChecksumAlgorithm.SHA1, "da39a3ee5e6b4b0d3255bfef95601890afd80709"))
else:
file_entry.set_checksum(Checksum(ChecksumAlgorithm.SHA1, file_data.get('sha1') or ''))

file_license_detections = file_data.get('license_detections')
license_matches = get_matches_from_detection_mappings(file_license_detections)
Expand Down