With requirement for fingerprint, we now need to build pyicu. - #4498
With requirement for fingerprint, we now need to build pyicu.#4498jimjag wants to merge 1 commit into
Conversation
Update to-be-installed requirements as needed.
There was a problem hiding this comment.
Thanks for the report and the PR @jimjag
See my comments below on why we cannot update fingerprints just yet, as we want to continue to support python3.9
We can conditionally update fingerprints based on python versions like we do for click, attrs :
Line 73 in d171a74
Could you update the PR accordingly so we can check if the tests pass allright?
| extractcode-libarchive==3.5.1.210531 | ||
| fasteners==0.19 | ||
| fingerprints==1.2.3 | ||
| fingerprints==1.3.0 |
There was a problem hiding this comment.
We cannot upgrade fingerprints just yet, because they have removed support for python3.9, see https://github.com/opensanctions/fingerprints/blob/8eea92ff357e080c6c8bb0807352e7b5f83d9c14/pyproject.toml#L19C1-L19C28
This is not EOL yet: https://endoflife.date/python
Also why the tests are failing because we test and support python3.9.
Note also as mentioned in #4493 (comment), fingerprints is now unmaintained.
So we would want to consider switching to rigour in the future.
Update to-be-installed requirements as needed.
Fixes #4497
Tasks
Run tests locally to check for errors.