Repository navigation
fix(desktop): keep legacy storage migration on the main renderer - #407
Draft
adampeterhiggins wants to merge 2 commits into
Draft
adampeterhiggins wants to merge 2 commits into
adampeterhiggins wants to merge 2 commits into
Conversation
An auxiliary preload could consume the one-shot V1 import. Take and complete now require the current main window, including before that ref is assigned, and protocol handlers can be registered on an explicit session without changing the default one. Co-authored-by: Cursor <cursoragent@cursor.com>
A sync denial threw out of ipcMain.on before returnValue was assigned. Only that unauthorized-sender error on the take channel becomes null, so the renderer still gets a reply and the payload stays for the main window. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An auxiliary preload could consume the one-shot V1 import, and a denied sync take threw out of the IPC listener before a reply was assigned.
Take and complete now require the current main window, including before that ref is assigned. Protocol handlers can be registered on an explicit session without changing the default one. Only an unauthorized-sender error on the take channel becomes null, so the renderer still gets a reply and the payload stays for the main window. This does not activate the detached chat shell; the legacy quick-message panel stays operational.
This restacks the accepted session commits onto parent #406 (
ah/detached-chat-native-ownersat5f3cec64c06a78cd88927f45b12f891862ba1921). Foundation tracker: #397.Rebase onto that exact native SHA had no conflicts.
git range-diff e045d817e461fbed07dbc6d5a9c1f62fce4e8850..b29faf9a65452d134be0203976142f3327ab3807 5f3cec64c06a78cd88927f45b12f891862ba1921..589a952a8ca96ade83881e33cb63f75d811a086cis equivalent for both commits (788d8dbfba=501c6a4a63,b29faf9a65=589a952a8c).Validation: 20 focused tests passed (ElectronProtocol, DesktopIpc, legacy local storage migration). Desktop typecheck passed. Scoped lint on the six session files passed. Native ownership tests were not re-run; the rebase did not change those commits.
Grok 4.7 via Symphony Cursor coordinated GPT-6.1-Sol Codex.
Made with Cursor