Repository navigation
feat(desktop): keep quick message presentation across hide and crash - #428
Draft
adampeterhiggins wants to merge 2 commits into
Draft
adampeterhiggins wants to merge 2 commits into
adampeterhiggins wants to merge 2 commits into
Conversation
The panel needs a compact and expanded size that survives hide, blur, and reload, without turning on the detached shell. Presentation is optional on the bridge so older shells stay compact, and the shortcut still opens the legacy route on the default session. Grok 4.7 via Cursor. Co-authored-by: Cursor <cursoragent@cursor.com>
…was expanded A renderer death only cleared readiness, so the next shortcut waited on a page that would never come back, and the expanded rect stayed at whatever size and place it had on first open. Recovery now reloads on the main window's bounded schedule, and the expanded position is read back from the window. Grok 4.7 via Cursor. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quick-message panel forgot whether it was expanded, and a renderer crash left the next shortcut waiting on a page that would never come back. The expanded rect also stayed at the size and place from first open.
Presentation is now compact or expanded and survives hide, blur, and show. A crashed panel reloads on the main window's bounded schedule, and the expanded position is read back from the window. The live constructor still uses the default session,
#/quick-message, and only--t3code-window-role=quick-message.setPresentationis optional on the bridge, so an older shell stays compact. Nothing passes the isolation argument, so the floating shell stays inactive. Crash recovery still loads the legacy route; a later activation has to supply the isolated initial route.Stack: #397 → #406 → #407 → #426 → this. Base is
ah/detached-chat-shellat1be27198b0a456dc6370bf870b79a6bfc4cbce37.The two lifecycle commits were already rebased onto that SHA. The patch applied with no conflicts and did not reapply the prerequisite commits. Parent refs stay at foundation
758ad0b644721def9ec470fca2cc020b6f37935a, native5f3cec64c06a78cd88927f45b12f891862ba1921, session589a952a8ca96ade83881e33cb63f75d811a086c, and shell1be27198b0a456dc6370bf870b79a6bfc4cbce37.git range-diff 1f7851053b0666ee249388c043b4d041e84f244d..4645177c91a17ba57ee9ec10419f4549f9335004 1be27198b0a456dc6370bf870b79a6bfc4cbce37..f7039f67456e16f65148a08d3c3ca67c1b306472is equivalent for both commits (fe101b6aec=d017b1e4d7,4645177c91=f7039f6745).Validation: desktop quick-message and IPC tests, 24 passed. Inherited window-role and preload-verifier tests, 19 passed. Typecheck for desktop and contracts passed. Lint on the touched files passed. Integrated UI evidence is pending: the shell is inactive, and a live runtime was not authorized.
Grok 4.7 high 500K fast via Cursor Symphony/T3.
Made with Cursor