Repository navigation
Conversation
|
PR #8595 will probably replace this one, but keeping open for now. |
|
LFTM -- Is there a reason to do this? Just to make the move to the browser easier for IE10 users? |
|
@redmunds does this work with minified builds yet? I thought I herd that you got it working but the comment in the pr description says that it isn't working yet |
Yes, this is to get this to work for IE10 for the Firefox team working on in-browser version. This could have been fixed only for IE10 in an easier way -- this provides an easy way to also add other polyfills in the future.
No, this PR still doesn't work in minified builds. It will most likely be replaced by #8595, but I wanted to keep this open until I'm sure. |
|
#8595 is merged, so closing this one. |
This is an attempt to implement functionality from pull request #7231, and also work with minified builds, but it's not yet working. Brackets works (based on very minimal usage), but the polyfill is not applied.
To create and run a minified build locally:
grunt buildShiftkey when starting Bracketsindex.html, usesrc/dist/index.htmlTesting Polyfill Mechanism
The polyfill added to
utils/Compatibility.jsin this PR is for IE10, so I added atrimAll()polyfill to that file locally so this could be tested in current desktop Brackets (i.e. CEF3 Chrome):I then created a
trimTestextension where contents ofmain.jsis:To test:
Use Debug > Trim Test
success:
alert()says: testString: ' this is a test string '; testString.trimAll(): 'thisisateststring'failure:
alert()says: "trimAll is not defined"