This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Repository navigation
Fix PR 7231 for minified build - #8595
Merged
Merged
Conversation
…o humphd/ie10-support
Contributor
Author
|
Updated based on comment in original PR. |
Contributor
|
@redmunds There are currently 2 open prs for this -- can we close this one? |
Contributor
Author
|
@JeffryBooher I think this is the fix we want. I was keeping #8593 open until we are sure. |
Contributor
|
This looks right and I tested it in a minified build. I noticed that the JavaScript formatter I used to expand dist/main.js didn't do a very good job of it and made it appear that the compatibility shim wasn't properly loaded, but I tested with a console.log statement and it is most definitely being loaded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make @#7231 work with Brackets minified build.