Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix PR 7231 for minified build - #8595

Merged
dangoor merged 7 commits into
masterfrom
randy/pr-7231
Aug 5, 2014
Merged

dangoor merged 7 commits into
masterfrom
randy/pr-7231

Conversation

@redmunds

Copy link
Copy Markdown
Contributor

This is to make @#7231 work with Brackets minified build.

@redmunds

Copy link
Copy Markdown
Contributor Author

Updated based on comment in original PR.

@redmunds redmunds changed the title [Review Only] Fix PR 7231 for minified build Fix PR 7231 for minified build Jul 30, 2014
@JeffryBooher

Copy link
Copy Markdown
Contributor

@redmunds There are currently 2 open prs for this -- can we close this one?

@redmunds

redmunds commented Aug 4, 2014

Copy link
Copy Markdown
Contributor Author

@JeffryBooher I think this is the fix we want. I was keeping #8593 open until we are sure.

@dangoor

dangoor commented Aug 5, 2014

Copy link
Copy Markdown
Contributor

This looks right and I tested it in a minified build. I noticed that the JavaScript formatter I used to expand dist/main.js didn't do a very good job of it and made it appear that the compatibility shim wasn't properly loaded, but I tested with a console.log statement and it is most definitely being loaded.

dangoor added a commit that referenced this pull request Aug 5, 2014
Fix PR 7231 for minified build
@dangoor
dangoor merged commit 791bcc4 into master Aug 5, 2014
@dangoor
dangoor deleted the randy/pr-7231 branch August 5, 2014 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants