eslint v5 support

Just like #1447, I'm filing this in advance.

v17.0.0 of eslint-config-airbnb and v13.0.0 of eslint-config-airbnb-base have just been released.

eslint v5 is planned to be released in the next 24-48 hours, and the plan for our configs will be to either support v3 || v4 || v5, or, if necessary, to drop support for v3 and/or v4 as part of this release.

The timeframe is "probably not as soon as you would like, but as soon as we can".
Please accept this, and please add no noise to this thread beyond emoji reactions - distractions won't help anyone get the work done any faster.

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v4 until such time as our configs support v5.

Peer Dep eslint combined v3 and v4 and v5 support released, or v5 support released (depending on which path we need to take):

Reverted ESLint to v4 until airbnb/javascript#1834 is fixed

Ignore eslint updates until supported by eslint-config-airbnb-base

Thank you for the great work. It looks like the remaining tasks on the list are the publishing tasks. Do you have any estimates on when to expect the new version to be published?

I'm waiting on a few bugs (that i've just added).

@ljharb

Hey @ljharb, curious what that status is on this. I saw some bugfixes landed in jsx-a11y-plugin.

I would love to read why "react/jsx-one-expression-per-line" is enabled. Is there a trend for developers to rotate their monitors vertically after this change 😆

This changes one readable line

<App>Hello World</App>

to an uncomfortable syntax

<App>
  { 'Hello' }
  { ' ' }
  { 'World' }
</App>

@danactive

@danactive That rule was turned off in b6a268f.
Hopefully the next release that includes the commit above will be out soon.

Your concern was also brought up here and here.

eslint-config-airbnb v17.1.0 and eslint-config-airbnb-base v13.1.0 have been released, with eslint 5 support.

Yeah!

Update eslint-config-airbnb to version with eslint 5 support

Is anyone still having the same issue after upgrading?

Here are my devDependencies, but I am still running into the same issue.

`
"eslint": "^5.3.0",

    "eslint-config-airbnb": "^17.1.0",

    "eslint-config-airbnb-base": "^13.1.0",

    "eslint-loader": "^2.1.0",

    "eslint-plugin-import": "^2.14.0",

    "eslint-plugin-jsx-a11y": "^6.1.1",

    "eslint-plugin-react": "^7.10.0",

`

Am I doing something wrong?

@kmaitski

@kmaitski what does npm ls say? Have you tried running the peer deps install command in the readme for eslint-config-airbnb?

Either way, please file a new issue if you're still having trouble.

Upgrade lint plugins for ESLint v5 compatibility

Navigation Menu

Repository navigation

eslint v5 support #1834

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v4 until such time as our configs support v5.

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

eslint v5 support #1834

Description

Please do not file additional issues and do not file pull requests attempting to add support - please, instead, continue to use eslint v4 until such time as our configs support v5.

Activity

YasharF commented on Jul 6, 2018

ljharb commented on Jul 6, 2018

bjankord commented on Jul 20, 2018

danactive commented on Jul 29, 2018

ryansully commented on Jul 29, 2018

tunnckoCore commented on Aug 1, 2018

stepankuzmin commented on Aug 13, 2018

ljharb commented on Aug 13, 2018

ljharb commented on Aug 13, 2018

tunnckoCore commented on Aug 14, 2018

kmaitski commented on Aug 17, 2018

ljharb commented on Aug 17, 2018

ljharb commented on Aug 17, 2018

noahbenham commented on Aug 17, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions