Repository navigation
fix(app): make links in user messages clickable - #57211
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
URLs in user message bubbles are now real links, so
https://github.com/Hona/meshin a prompt can be clicked instead of copied by hand.http(s)://URLs in the plain-text segments of a user message render as<a target="_blank" rel="noopener noreferrer">. The desktop window-open handler already sends these to the system browser; on web they open in a new tab, the same as assistant markdown links.,.)]and similar) stays outside the link, matching how tool output already extracts URLs.Tests
linksscenario in theConversationtimeline story.href,target, punctuation trimming, the mention, and that the full text content is unchanged.session-message-projection.spec.tspasses locally (7/7), andsession-uitypecheck passes.Before/after screenshots in dark and light themes were shared in the Slack thread.
Requested by: @neriousy (Filip via Slack)