Repository navigation
fix(session-ui): show pointer cursor on user message links - #57304
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links in user messages (added in #57211) rendered with the default cursor, because the base link reset sets
cursor: defaulton everyaand the newuser-message-linkstyle didn't opt back in. This addscursor: pointerto[data-slot="user-message-link"].Verification
current-session-timeline-rows--conversationstory with thelinksscenario, the link's computed cursor isdefaultbefore this change andpointerafter.toHaveCSS("cursor", "pointer")assertion to the existing user-message link component test.Requested by: @Brendonovich (Brendan via Slack)