Repository navigation
GH-47277: [C++] r-binary-packages nightly failures due to incompatibility with old compiler - #47299
Merged
Merged
Conversation
Member
Author
|
@github-actions crossbow submit r-binary-packages |
|
Revision: 8a2d1b8 Submitted crossbow builds: ursacomputing/crossbow @ actions-da716f4052
|
This was referenced Aug 9, 2025
jonkeane
approved these changes
Aug 9, 2025
jonkeane
left a comment
Member
There was a problem hiding this comment.
What a simple fix! The GLib job is failing on main, this is good to go IMHO
Thanks for this!
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 135357c. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Member
|
Wow, interesting that such a hack is needed for old gccs (version 8.3.1 apparently). @EnricoMi FYI. |
Member
|
And thank you @thisisnic for finding the fix! |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…patibility with old compiler (apache#47299) ### Rationale for this change The `r-binary-packages` job (specifically [C++ Binary Linux OpenSSL 1.0](https://github.com/ursacomputing/crossbow/actions/runs/16314662786/job/46077638701#logs) and 1.1) has been failing since 15th July with this error: ``` /arrow/cpp/src/parquet/encryption/encryption.h:175:62: error: use of deleted function 'arrow::util::SecureString::SecureString()' : column_path_(std::move(path)), encrypted_(encrypted) {} ^ In file included from /arrow/cpp/src/parquet/encryption/encryption.h:26, from /arrow/cpp/src/parquet/properties.h:30, from /arrow/cpp/src/parquet/arrow/path_internal.cc:109: ``` ### What changes are included in this PR? Remove the unconditional `noexcept` from `SecureString`’s default constructor so its exception specification now matches `std::string`’s on all libstdc++ versions. ### Are these changes tested? No but I'll run the failing CI job ### Are there any user-facing changes? No * GitHub Issue: apache#47277 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
r-binary-packagesjob (specifically C++ Binary Linux OpenSSL 1.0 and 1.1) has been failing since 15th July with this error:What changes are included in this PR?
Remove the unconditional
noexceptfromSecureString’s default constructor so its exception specification now matchesstd::string’s on all libstdc++ versions.Are these changes tested?
No but I'll run the failing CI job
Are there any user-facing changes?
No