Repository navigation
datafusion-cli cursor isn't on the right position in windows 7 cmd #9501
Description
Describe the bug
use pageup key to get the history command,
if I move the cursor to the left position of g and press (, it insert the ( after g
❯ select g(enerate_series(1,10);
To Reproduce
datafusion-cli
input
select g(enerate_series(1,10);
+-------------------------------------+
| generate_series(Int64(1),Int64(10)) |
+-------------------------------------+
| [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] |
+-------------------------------------+
```
then
use pageup key to get the history command,
if I move the cursor to the left position of g and press `(`
### Expected behavior
insert `(` before g
### Additional context
_No response_
Activity
l1t1 commentedon Mar 13, 2024
maybe the root of the problem is the prompt
❯is a utf-8 character, it occupied multi-bytes, suggest use an ASCII charactor, such as>l1t1 commentedon Mar 13, 2024
this prompt displayed as a box in cmd of windows 7
alamb commentedon Mar 18, 2024
Thanks for the report @l1t1
Maybe we could change the prompt character on windows (perhaps to
>) ?alamb commentedon Mar 18, 2024
I think this is a good first issue for someone with a windows machine to test on
colommar commentedon Apr 10, 2024
@alamb Hi! I have a windows machine and changed all those
❯to>. Is this OK?And I wanna test if the change does work how can I rebuild the datafusion to update the change by using the command
datafusion-clialamb commentedon Apr 10, 2024
Great @colommar !
To test the change locally you can do something like this
cd datafusion/datafusion-cli cargo runcolommar commentedon Apr 10, 2024
@l1t1 I guess it was fine now. Can you help me test it on your pc?
l1t1 commentedon Apr 10, 2024
could you attach the binary file?
colommar commentedon Apr 10, 2024
@l1t1 Sure! Is this OK? Does it help you?
datafusion-cli.zip
l1t1 commentedon Apr 11, 2024
it works, very thanks