Skip to content

Fix datafusion-cli cursor isn't on the right position in windows 7 cmd - #10028

Merged
alamb merged 1 commit into
apache:mainfrom
colommar:main
Apr 11, 2024
Merged

alamb merged 1 commit into
apache:mainfrom
colommar:main

Conversation

@colommar

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #9501

Rationale for this change

maybe the root of the problem is the prompt ❯ is a utf-8 character, it occupied multi-bytes, suggest use an ASCII charactor, such as >

What changes are included in this PR?

change all ❯ into >

Are these changes tested?

Are there any user-facing changes?

when using the datafusion-cli, instead of ❯ select g(enerate_series(1,10);, they will get >select g(enerate_series(1,10);

@github-actions github-actions Bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate labels Apr 10, 2024
@alamb alamb changed the title fix#9501 Fix datafusion-cli cursor isn't on the right position in windows 7 cmd Apr 10, 2024

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thank you @colommar

Any thoughts @jimexist ?

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simpler to me. Thanks @colommar

@alamb
alamb merged commit feb9100 into apache:main Apr 11, 2024
appletreeisyellow pushed a commit to influxdata/arrow-datafusion that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

datafusion-cli cursor isn't on the right position in windows 7 cmd

3 participants