Skip to content

chore: resolve dependency security advisories - #1486

Merged
dannyhw merged 3 commits into
mainfrom
dannyhw/audit-fixes
Oct 9, 2026
Merged

dannyhw merged 3 commits into
mainfrom
dannyhw/audit-fixes

Conversation

@dannyhw

@dannyhw dannyhw commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Resolves most open Dependabot alerts and pnpm audit findings, preferring version updates over overrides. pnpm audit goes from 99 (3 critical, 58 high) to 6 (0 critical, 3 high). None of the 6 that remain have a fix that can be reached without an override.

Shipped packages

  • @callstack/repack: image-size ^1.2.1 → ^2.0.4 (ICNS/JXL/HEIF infinite-loop DoS; no 1.x fix exists). This is a major bump, but our only call site is imageSize(buffer) in the assets loader, and that API is the same in v2. Engines stay at node >=18, and nothing about image-size is exposed to consumers.
  • @callstack/repack-dev-server: fastify floor ^5.10.0 → ^5.12.5 (several advisories, all within 5.x).

Tester apps / website / tooling (internal)

  • @module-federation/enhanced / runtime (testers catalog) 2.8.0 → 2.9.2. This release ships patched undici/ws/adm-zip, so the dts-plugin@2.8.0>undici override is removed.
  • @rsdoctor/rspack-plugin 1.5.2 → 1.6.4 (unauthenticated HTTP API advisory; 1.6.5 is still inside the minimumReleaseAge window).
  • @rspress/core 2.0.0 → 2.0.23 (drops vulnerable tinypool).
  • vitest catalog ^4.1.0 → ^4.1.11.
  • Ruby json gem 2.21.1 → 2.21.2 in the tester apps' Gemfile.lock.
  • Re-resolved transitive deps within their existing ranges: shell-quote, axios, fast-uri, @xmldom/xmldom, joi, js-yaml, svgo, brace-expansion, engine.io, source-map-js, compression, qs, nanoid.

Overrides

  • Kept koa@2, koa@3, ws@8, adm-zip (raised to ^0.6.1). These are now only reached through the older MF versions pinned on purpose for compatibility coverage (packages/repack devDep 0.8.9, tests/integration 2.0.1/0.15/0.21). The comment has been updated to say this.
  • No new overrides added.

Remaining (no fix reachable without an override)

Package Path Reason
image-size 1.x tester-expo → metro metro pins ^1.x
decode-uri-component tester-expo → expo-router → query-string 7 needs 0.5 (ESM-only), incompatible with query-string 7
postcss-selector-parser tester-app → tailwindcss 3 needs v7; tailwind 3 requires v6
node-forge, braces, sprintf-js expo cli / babel cli / changesets no patched version published

Test plan

  • pnpm build, pnpm typecheck, pnpm test pass
  • Integration assets-loader snapshots (width/height) unchanged with image-size v2
  • pnpm lint:ci (only an existing warning in repack-expo)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
repack-website Ready Ready Preview Oct 9, 2026 8:04pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 49bb712

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-plugin-expo-modules Patch
@callstack/repack-plugin-nativewind Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dannyhw
dannyhw merged commit fd8e33e into main Oct 9, 2026
10 checks passed
@dannyhw
dannyhw deleted the dannyhw/audit-fixes branch October 9, 2026 20:23
dannyhw added a commit that referenced this pull request Oct 9, 2026
Resolve conflicts with the dependency security updates (#1486):
- apps/tester-federation stays removed
- keep vite 8 / vitest 5 from v6 in the catalog
- regenerate pnpm-lock.yaml from main's lockfile so its transitive
  security bumps carry over

This branch was successfully deployed

1 active deployment
Preview — 49bb712c Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant