Skip to content

chore: update metro to drop vulnerable image-size 1.x - #1488

Merged
dannyhw merged 1 commit into
mainfrom
dannyhw/metro-image-size
Oct 9, 2026
Merged

dannyhw merged 1 commit into
mainfrom
dannyhw/metro-image-size

Conversation

@dannyhw

@dannyhw dannyhw commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #1486. The last copy of image-size@1.2.1 (flagged by the ICNS/JXL/HEIF infinite-loop DoS advisories) came in through metro@0.84.4, via @react-native/community-cli-plugin@0.86.3 in the tester apps. Metro 0.84.5+ no longer depends on image-size.

@react-native/community-cli-plugin already allows metro ^0.84.3, so this is a lockfile-only update within existing ranges. No package.json changes, no overrides.

  • metro and metro-* 0.84.4 → 0.84.6 (@expo/metro still pins its own 0.84.5, which also doesn't use image-size)
  • image-size@1.2.1 is removed; only 2.0.4 (used by @callstack/repack) remains
  • Updated alongside metro within their ranges: terser 5.51.2 (metro's minifier), @babel/parser/@babel/types, acorn

Resolves the remaining image-size Dependabot alerts (lockfile path).

Test plan

  • pnpm build, pnpm typecheck, pnpm test (repack 354, integration 128, metro-compat 47, dev-server 28, resolver-cases 13, tester-app 14)
  • Release bundles for tester-app (Rspack iOS/Android, webpack iOS), MF v1 and v2 host/mini, Expo app, Expo widget production build, and website build all succeed
  • Release bundle sizes are byte-for-byte the same as before, so minification is unaffected

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
repack-website Ready Ready Preview Oct 9, 2026 8:37pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 957cdd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dannyhw
dannyhw merged commit 8f50dff into main Oct 9, 2026
10 checks passed
@dannyhw
dannyhw deleted the dannyhw/metro-image-size branch October 9, 2026 21:05
dannyhw added a commit that referenced this pull request Oct 9, 2026
Resolve the pnpm-lock.yaml conflict with the metro update (#1488) by
regenerating it from main's lockfile with v6's dependency changes applied.

This branch was successfully deployed

1 active deployment
Preview — 957cdd8c Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant