Improve phpstan level #143

Activity

1. njoubert-cleverage

   added

   enhancement

   on Oct 18, 2024
2. njoubert-cleverage

   added this to the v5.0 milestone on Dec 16, 2024
3. njoubert-cleverage

   modified the milestones: v5.0, v6.0 on Dec 9, 2025
4. njoubert-cleverage

   removed this from the v6.0 milestone on Oct 9, 2026
5. njoubert-cleverage

   self-assigned this

   on Oct 9, 2026
6. njoubert-cleverage

   added 4 commits that reference this issue on Oct 9, 2026

   chore(quality) #143 Remove all PHPStan ignores at level 6: add missin…

   ...

   21f5c9e

   Merge pull request #238 from cleverage/143

   ...

   ab15ded

   Merge pull request #252 from cleverage/143-level-8

   ...

   81a28b7

   Merge pull request #254 from cleverage/143-option-types

   ...

   23a667b
7. njoubert-cleverage commented on Oct 9, 2026

   

   njoubert-cleverage

   on Oct 9, 2026

   MemberAuthor

   More actions

   Progress

   Current state on main: PHPStan level 7, no ignoreErrors, no @phpstan-ignore.

   Done

   • Remove all ignoreErrors and @phpstan-ignore-* comments, level 6 clean — #143 - Remove all PHPStan ignores at level 6 #238
   • Level 6 → 7, plus every level 8 error that can be fixed without breaking backward compatibility — #143 - Improve PHPStan level from 6 to 7 #252
   • Type the remaining untyped task options (split_character, write_headers, log_empty_lines) — #143 - Type the remaining untyped task options #254

   Edge cases found along the way were fixed and tested (e.g. InputIteratorTask with a nested IteratorAggregate, CsvResource blank header line, XpathEvaluatorTransformer invalid query / namespace nodes, SlugifyTransformer invalid UTF-8).

   Planned for v6.0 (draft PRs)

   • Level 7 → 8: the 16 remaining errors come from native nullable types that are never null in practice (AbstractConfigurableTask::getOptions(): ?array, ProcessState::getContextualizedOptions(): ?array, CsvResource::$lineNumber, ProcessHistory::$startDate). Narrowing them is a BC break — [v6] #143 - Narrow nullable native types, improve PHPStan level to 8 #253 (milestone v6.0)
   • cleverage/process-bundle#143 - ZipTask and UnzipTask: compatibility with process-bundle v6.0 archive-process-bundle#24 (milestone v2.3): ZipTask / UnzipTask override getOptions(): ?array, fatal with [v6] #143 - Narrow nullable native types, improve PHPStan level to 8 #253. Compatible with v5 and v6, must be released before process-bundle v6.0

   Next (v6.x, no BC expected)

   • Levels 9 and 10: ~500 errors, mostly mixed values read from $options[...]. The analysis on the v6 branch shows they can all be fixed with PHPDoc and local type narrowing, without changing native signatures, so they do not require another major version.