Repository navigation
#143 - Remove all PHPStan ignores at level 6 - #238
Merged
Merged
Conversation
…g iterable value and generic types in PHPDoc, remove unreachable code, fix InputIteratorTask with an IteratorAggregate not returning an Iterator Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
njoubert-cleverage
force-pushed
the
143
branch
from
October 9, 2026 08:31
c437b22 to
21f5c9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #143 (step 1 of 3: levels 7-8, then 9-10 will follow in separate PRs, so the issue stays open).
phpstan.neonhid 219 level 6 errors behind 9ignoreErrorspatterns, withreportUnmatchedIgnoredErrors: falsemasking the ones that no longer matched anything. This PR keeps level 6 and removes every ignore:ignoreErrorsandreportUnmatchedIgnoredErrors: falsefromphpstan.neon;array<string, mixed>(TransformerInterface::transform()and all its implementations,ProcessState,ProcessManager, events, logger processors…), task codes aslist<string>inProcessConfiguration/TaskConfiguration,\SplQueue<…>,Options<array<string, mixed>>,array<string, \Closure>for normalized transformers, CSV headers and lines;@phpstan-ignore-next-line: the one inProcessLauncherTaskwas no longer needed, the one inAbstractIterableOutputTaskhid an unreachable check ($iteratoris a?\Iterator, it is alwaysnullat this point);InputAggregatorTask: remove the always-false!$previousState->getTaskConfiguration()check (non-nullable return type);InputIteratorTask: an\IteratorAggregateinput whosegetIterator()does not return an\Iterator(e.g. another\IteratorAggregate) failed with aTypeError; it is now wrapped in an\IteratorIterator. AddInputIteratorTaskTest, precise the reference documentation.On
main, only the nestedIteratorAggregatetest fails (TypeError). PHPStan (level 6, no ignore), PHPUnit (255 tests), PHP-CS-Fixer and Rector pass.Requirements
Breaking changes
None: only PHPDoc is added, native signatures are unchanged. Projects analysing their own code extending these classes with PHPStan may get more precise types.
🤖 Generated with Claude Code