Repository navigation
Conversation
Turbo87
reviewed
Nov 4, 2019
Turbo87
left a comment
Contributor
There was a problem hiding this comment.
keep in mind that this is a breaking change and needs a major version bump
| - "8" | ||
| - "10" | ||
| - "12" | ||
| - "node" |
Contributor
Author
There was a problem hiding this comment.
keep in mind that this is a breaking change and needs a major version bump
Exactly.
Contributor
Author
There was a problem hiding this comment.
we should be explicit here
Why not fail early?
Contributor
There was a problem hiding this comment.
because we'd lose coverage for 13 once 14 is released
Contributor
Author
There was a problem hiding this comment.
This is fine imo as odd release numbers are shortliving anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current eslint version needs NodeJS >= 8.
See https://travis-ci.com/cli-table/cli-table3/jobs/252453197