Skip to content

ci: remove NodeJS 6 and add NodeJS latest (13) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielRuf wants to merge 1 commit into from
Closed

ci: remove NodeJS 6 and add NodeJS latest (13) #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: node_js
node_js:
- "6"
- "8"
- "10"
- "12"
- "node"

@Turbo87 Turbo87 Nov 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be explicit here

@DanielRuf DanielRuf Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep in mind that this is a breaking change and needs a major version bump

Exactly.

@DanielRuf DanielRuf Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be explicit here

Why not fail early?

@Turbo87 Turbo87 Nov 6, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we'd lose coverage for 13 once 14 is released

@DanielRuf DanielRuf Nov 6, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine imo as odd release numbers are shortliving anyways.


cache: yarn

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
},
"homepage": "https://github.com/cli-table/cli-table3",
"engines": {
"node": ">=6"
"node": ">=8"
},
"changelog": {
"repo": "cli-table/cli-table3",
Expand Down