[lei-tang]

Per the request from cloudendpoints/endpoints-tools#61,

1. Add 22 tests for start_esp to check that the ESP nginx configuration file generated are as expected.
2. Add 9 tests for start_esp to check that the ESP server configuration file generated are as expected.

This PR depends on cloudendpoints/endpoints-tools#66, so it should be committed after cloudendpoints/endpoints-tools#66 is merged in the endpoints-tools repo and the endpoints-tool repo SHA is updated.

[qiwzhang]

Thanks. I think the test should be in esp_tools repo: if there are some changes, many golden files need to be updated. Otherwise the test will fail. We want the author making the change to fix the test too.

But our Jenkins presubmit tests only run for esp repo. We don't have auto tests for esp_tools repo.

Not sure how easy to setup Jenkins in esp_tools repo.

Another option is to move files in start_esp folder into esp repo. Then, we can add test here.

[lei-tang]

I am leaning towards the option of moving files in start_esp folder into esp repo because:

1. with this option, start_esp.py and its related tests can be edited and run in ESP repo without updating and syncing to the SHA of endpoints-tools.
2. with this option, ESP repo no longer needs to copy start_esp.py and nginx conf template from endpoints-tools repo. Though these files are stored in the endpoints-tools repo, they are only used in the ESP repo. So it is natural to move them into the ESP repo. Plus, the developers will be able to work on the ESP repository only instead of two repositories (ESP and endpoints-tools).

[qiwzhang]

Yes, SGTM. Let us create a PR to move the files first, then this PR.

[lei-tang]

The PR #420 and cloudendpoints/endpoints-tools#69 are created to move start_esp from the endpoints-tools repository to the ESP repository.

[lei-tang]

@qiwzhang
This PR has been rebased to the latest moved start_esp code (Move start_esp from the endpoints-tools repository to the ESP repository 29452e3).

It has passed the presubmit test and e2e tests: https://endpoints-jenkins.appspot.com/job/esp/job/presubmit/1110/, https://endpoints-jenkins.appspot.com/job/jenkins-testing/job/pr-e2e/119/

Please review it again.