Repository navigation
Move start_esp from the endpoints-tools repository to the ESP repository - #420
Merged
Merged
Conversation
lei-tang
commented
Jul 20, 2018
Contributor
- Move start_esp from the endpoints_tools repository to the ESP repository.
- With this refactoring, the ESP repository no longer depends on the endpoints_tools repository. start_esp and its related tests can be edited and run in ESP repo without updating and syncing to the SHA of endpoints-tools. The ESP developers will be able to work on the ESP repository only instead of on two repositories (ESP and endpoints-tools).
- Move start_esp from the endpoints_tools repository to the ESP repository. - With this refactoring, the ESP repository no longer depends on the endpoints_tools repository. start_esp and its related tests can be edited and run in ESP repo without updating and syncing to the SHA of endpoints-tools. The ESP developers will be able to work on the ESP repository only instead of on two repositories (ESP and endpoints-tools).
Merged
qiwzhang
previously approved these changes
Jul 20, 2018
Contributor
|
Please make sure it pass e2e test before submit. Use Jenkins pr-e2e test to test it. |
Contributor
Author
|
@qiwzhang This PR has passed the e2e test: https://endpoints-jenkins.appspot.com/job/jenkins-testing/job/pr-e2e/118/. It needs your review approval before it can be merged. |
qiwzhang
approved these changes
Jul 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.