Repository navigation
Minimum supported PyTorch version? #24
Description
Activity
correctionisn't documented, but it is present in 1.13.>>> import torch >>> torch.__version__ '1.13.0' >>> torch.std(torch.arange(3, dtype=torch.float32), (0,), correction=2) tensor(1.4142)
I've tested all the pytorch support against 1.13 so things should work there. I haven't tested against 2.0 yet, but don't expect too many breakages.
We should probably support at least 1.13 and 2.0 for now. Let me know if supporting anything earlier is important for you.
correctionwas only recently updated to accept floats in addition to integers. Maybe that's the issue?From the weekly call,
correctionmust be an int to support 1.13.- added a commit that references this issue
on Mar 7, 2023 As a minimum reproducer, the following fails on 1.13:
import torch import array_api_compat x = torch.asarray([1.0, 2.0, 3.0]) xp = array_api_compat.get_namespace(x) xp.std(x) # TypeError: std() received an invalid combination of arguments - got (Tensor, tuple, correction=float), but expected one of: # * (Tensor input, tuple of ints dim, *, int correction, bool keepdim, Tensor out) # * (Tensor input, tuple of ints dim, bool unbiased, bool keepdim, *, Tensor out) # * (Tensor input, bool unbiased) # * (Tensor input, tuple of names dim, *, int correction, bool keepdim, Tensor out) # * (Tensor input, tuple of names dim, bool unbiased, bool keepdim, *, Tensor out)
Setting
correctionto anintworks, i.e.xp.std(x, correction=0).
Similar to #21 but for other array libraries. For example, PyTorch
correctionwas is in 2.0, but not in previous versions. The following fails for PyTorch < 2.0:array-api-compat/array_api_compat/torch/_aliases.py
Line 378 in e2203df
For reference, here are the
torch.stddocs for 1.13 and 2.0.