Repository navigation
Various fixes for the torch wrapper - #25
Merged
Merged
Conversation
This allows shape to be passed as a keyword argument. Fixes data-apis#22.
GitHub Actions expressions are very limited in what you can do with them. The default cannot reference another variable, and there is no way to do manipulation or "if" clauses with them.
The equal_nan keyword to unique() and np._CopyMode aren't in this version.
Member
Author
|
This is ready for review. |
rgommers
approved these changes
Mar 8, 2023
rgommers
left a comment
Member
There was a problem hiding this comment.
These changes LGTM. One CI job for numpy 1.21 still has 8 failures, which all don't look too interesting (~1e-46 inputs to some ufuncs).
Member
Author
|
No worried on CI. It typically takes a few iterations to get all the possible XFAILs from hypothesis. |
Member
Author
|
(and just to be clear, those failures are all because of value-based type promotion, which we cannot disable in NumPy 1.21) |
Member
Author
|
Now NumPy is crashing on CI with a floating-point exception https://github.com/asmeurer/array-api-compat/actions/runs/4368929147/jobs/7642133923. There must be some issue with mod in the C math library used on GitHub Actions. |
asmeurer
enabled auto-merge
March 9, 2023 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily from @thomasjpfan's feedback.