Repository navigation
docs(mcpx): opencode-plugin-v2 implementation map prescribes a daemon.ts re-export path that does not resolve (PR #2457) #3248
Description
Finding
pkgs/mcpx/docs/opencode-plugin-v2.md line 137 — the implementation map for the #1858 v2 plugin port — prescribes the wrong re-export path for the v2 daemon.ts:
|
daemon.ts| re-export of../../mcpx/daemon.ts| core reuse |
The row describes plugin/opencode/v2/daemon.ts. From that directory, ../../mcpx/daemon.ts resolves to pkgs/mcpx/plugin/mcpx/daemon.ts, which does not exist. The daemon module actually lives at pkgs/mcpx/plugin/opencode/mcpx/daemon.ts, so from plugin/opencode/v2/ the correct relative path is ../mcpx/daemon.ts. A v2 file copied from this row fails to resolve its import.
Evidence
- Source PR: docs(mcpx): verified opencode v2 plugin facts and the core-rewrite map (#1858 groundwork) #2457 (merged b1160f4) added the doc as mcpx: port the opencode plugin to opencode v2 (a rewrite, and several things get better) #1858 groundwork. CodeRabbit comment 4418944915 raised exactly this on the PR, with the one-line fix; it received no reply and the doc merged unchanged.
- Verified live on main 8f24c7d: line 137 still reads
../../mcpx/daemon.ts;git ls-treeshowspkgs/mcpx/plugin/contains onlyopencode/, and the daemon module is atpkgs/mcpx/plugin/opencode/mcpx/daemon.ts(withdaemon.test.tsbeside it).
Why it matters
This doc is the map the #1858 rewrite (and its SET-REMAINDER #2841) is implemented from. A wrong path in the map becomes a broken import in the first v2 file that follows it, discovered later and further from the source.
Acceptance criteria
- Line 137 (and any other row in the map with a relative path) resolves to a file that exists in the tree at the commit it lands on.
- The v2 implementation, when it lands, can copy the row verbatim and have the import resolve.
Activity
dezren39 commentedon Oct 31, 2026
Agent: pr-diff-review-b
State: filed
Finding source: PR diff review lane B, run 2026-10-31 18:18 CDT. This issue was filed from a verified review finding on the source PR named in the issue title/body; the finding was re-verified against current main before filing and deduped against open and recently closed issues. A repo-task/v1 triage packet has been enqueued for this issue on the repo-health-code-pilot queue.
dezren39 commentedon Oct 31, 2026
🤖 Agent note · picked up
11 remaining items
dezren39 commentedon Nov 1, 2026
🤖 Agent note · resumed — merging (task 4757, PR #3259)
../mcpx/daemon.ts. MergeStateStatus CLEAN. Merging now; then reply+resolve on PR docs(mcpx): verified opencode v2 plugin facts and the core-rewrite map (#1858 groundwork) #2457 thread 4418944915 and complete fixed_merged.Merge pull request #3259 from developing-today/queue/4757-3248-daemon…
dezren39 commentedon Nov 1, 2026
🤖 Agent note · done — fixed & merged (task 4757)
pkgs/mcpx/docs/opencode-plugin-v2.mdnow reads../mcpx/daemon.ts(verified on main, line 137; resolves to the existingpkgs/mcpx/plugin/opencode/mcpx/daemon.ts). All PR checks pass; Codex review completed with zero findings. PR docs(mcpx): verified opencode v2 plugin facts and the core-rewrite map (#1858 groundwork) #2457 CodeRabbit thread 4418944915 replied to (comment 4433859452) and resolved. Issue closed by the merge; in-flight labels removed.