github-backup(deploy): --dry-run is ignored on the --deploy-version path — a rollback preview creates a real 100% deployment

Finding (from PR review)

Codex P1 on PR #3280 (chatgpt-codex-connector[bot], 2026-11-01T01:33:18Z): "Honor dry-run when deploying an existing version" — #3280 (comment)

When an operator combines --dry-run with --deploy-version <id> to preview a rollback, this branch runs before the dry-run check and immediately changes the production deployment. Running the actual script with mocked executables confirmed that it invokes wrangler versions deploy <id>@100% --name developing-today-backup --yes, without forwarding --dry-run. Wrangler documents the deployment command's --dry-run option as "Don't actually deploy," but the wrapper silently discards that protection and bypasses confirmation. Forward the dry-run flag for existing-version deployments, or reject the combination before making any changes.

No-response evidence

PR github-backup: rename to developing-today-backup + just/nix deploy standard #3280 merged with the finding unaddressed: the inline comment has no replies, and GraphQL reviewThreads for PR github-backup: rename to developing-today-backup + just/nix deploy standard #3280 shows all 3 threads isResolved=false.
No fix commit after the comment: the defect is still present on current main (below).

Still-live evidence (verified this run, current main)

infra/github-backup/worker/deploy.mjs (current main):

The --deploy-version branch runs before the dry-run check and exits:

if (deployVersion !== null) {
  createDeployment(deployVersion);
  reportLive();
  process.exit(0);
}
if (dryRun) { /* wrangler deploy --dry-run ... */ }

createDeployment() unconditionally runs wrangler versions deploy <id>@100% --name developing-today-backup --yes — no --dry-run forwarding, no rejection of the combination.

So deploy.mjs --dry-run --deploy-version <id> — the safest-looking way to preview a rollback — performs the real 100% deployment.

Dedupe / related

Sibling, not a duplicate: pkarr-worker(deploy): --dry-run is ignored on the --deploy-version path — a rollback preview creates a real 100% deployment #3252 files the identical defect in pkgs/pkarr-worker/deploy.mjs. That issue is scoped to the pkarr script only and does not cover this script (the fleet's established pattern is one issue per script — see github-backup(worker deploy): unrecognized arguments are silently ignored — a typo'd --dry-rnu performs a real deploy (upload + secret reset) #3287, filed for this same deploy.mjs's unrecognized-argument defect).
github-backup(worker deploy): unrecognized arguments are silently ignored — a typo'd --dry-rnu performs a real deploy (upload + secret reset) #3287 (unrecognized arguments silently ignored in this file) is a distinct defect.

Acceptance criteria

deploy.mjs --dry-run --deploy-version <id> creates no deployment: it either forwards --dry-run to wrangler or rejects the combination with a clear error before any wrangler call.
The non-dry-run --deploy-version path is unchanged.
A stubbed-executable regression test covers the combination (fails on current code).
Or the finding is resolved by a documented decision on this issue.

CODE-1330

🤖 Agent note · filed

Agent: pr-comment-review job
Session / ID: pr-comment-review 2026-11-01 03:54 CST
Found via: unaddressed PR comment, github-backup: rename to developing-today-backup + just/nix deploy standard #3280 (comment)
Task: PR github-backup: rename to developing-today-backup + just/nix deploy standard #3280 Codex P1 — --dry-run ignored on the --deploy-version path in deploy.mjs — filed for triage; queue worker verifies against current main before any fix
Expectation: s — done = defect fixed, or a documented decision on the issue
Links: github-backup: rename to developing-today-backup + just/nix deploy standard #3280 (comment)

🤖 Agent note · picked up

Agent: repo-worker-code (OpenChamber scheduled lane)
Session / ID: OpenCode scheduled lane 2026-11-01; queue task 5417 (triage, attempt 1)
Found via: claimed from repo-health-code-pilot queue
Task: Verify the reported --dry-run/--deploy-version interaction on current main and route the remaining fix without invoking a live deployment.

🤖 Agent note · picked up

Agent: queue worker (repo-worker-code), Lane D shift
Session / ID: queue task 5424
Found via: queue claim
Task: Fix deploy.mjs so --dry-run --deploy-version cannot perform a live deployment; add stubbed-executable regression test
Expectation: effort s; done = PR opened with the combination rejected before any wrangler invocation, ordinary rollback path unchanged, github-backup tests passing
Links: issue github-backup(deploy): --dry-run is ignored on the --deploy-version path — a rollback preview creates a real 100% deployment #3474

Merge pull request #3480 from developing-today/queue/5424-3474-dry-ru…

🤖 Agent note · done

Agent: queue worker (repo-worker-code), Lane D shift
Session / ID: queue task 5424
Found via: queue claim
Task: Fixed — deploy.mjs now rejects --dry-run combined with --deploy-version right after argument parsing, before any bws/wrangler invocation; ordinary rollback and plain dry-run paths unchanged
Expectation: met — PR github-backup(deploy): reject --dry-run with --deploy-version (#3474) #3480 merged (b6ea8d7), Codex review completed with no findings, new stubbed-executable test 11/11 (fails on unfixed code at the combo checks), existing github-backup suite green (54/54, 18/18, 9/9)
Links: PR github-backup(deploy): reject --dry-run with --deploy-version (#3474) #3480 · branch queue/5424-3474-dry-run-deploy-guard

Navigation Menu

Repository navigation

github-backup(deploy): --dry-run is ignored on the --deploy-version path — a rollback preview creates a real 100% deployment #3474

Finding (from PR review)

No-response evidence

Still-live evidence (verified this run, current main)

Dedupe / related

Acceptance criteria

4 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

github-backup(deploy): --dry-run is ignored on the --deploy-version path — a rollback preview creates a real 100% deployment #3474

Description

Finding (from PR review)

No-response evidence

Still-live evidence (verified this run, current main)

Dedupe / related

Acceptance criteria

Activity

developing-today commented on Nov 1, 2026

dezren39 commented on Nov 1, 2026

dezren39 commented on Nov 1, 2026

4 remaining items

dezren39 commented on Nov 1, 2026

dezren39 commented on Nov 1, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions