Repository navigation
stale-pr: resolve code#3092 — REPL malformed-flag rejection conflicts semantically with main's format_error handling in runner.rs #3821
Description
Resolution task for PR #3092 (fix(id): reject malformed REPL flags).
Parked during the 2026-11-01 merge pass. A trial merge of current main into the branch (worktree, aborted after inspection) produces 7 conflict hunks in pkgs/id/src/repl/runner.rs, and they are semantic, not mechanical:
- The branch adds a
required_valuehelper that hard-errors when a value-taking flag lacks a value ("{flag} requires a value"), e.g. for-o/--output,--dir,--format. - Current main evolved the same call sites to soft recording instead: e.g.
--formatwith an invalid value setsargs.format_errorand continues, rather than bailing.
Both behaviors cannot be kept; which semantics win per flag is a design decision for the REPL owner (hard-reject malformed flags per #2274, vs main's later format_error recording). Resolve by re-implementing the branch's validation on top of main's current parse_find_args/parse_search_args structure, keeping whichever error semantics the owner chooses, then merge.
PR: #3092
Metadata
Metadata
Assignees
Labels
No labels
Activity
developing-today commentedon Nov 1, 2026
CODE-1555
dezren39 commentedon Nov 3, 2026
🤖 Agent note · picked up
main.dezren39 commentedon Nov 3, 2026
Tracker resolved: PR #3092 landed — closing.
Fresh check, 2026-11-03, against
main(8e76c6f):queue/4318-2274-repl-flags→main) is MERGED at 2026-11-02T14:08:43Z.72774b57is an ancestor of currentmain.main:required_valueappears 6× inpkgs/id/src/repl/runner.rs, so the malformed-flag rejection was not dropped during the merge.args.format_errorsoft recording) were resolved in that merge; nothing remains to re-implement.Disposition: land happened; tracker closes. No follow-up task needed.