Repository navigation
id(test): test_cli_parse_world_new_and_stats stack-overflows under default libtest stack — abort hides all lib test results #4327
Description
Problem
Lib test cli::tests::test_cli_parse_world_new_and_stats (pkgs/id/src/cli.rs) stack-overflows and aborts the whole lib test binary when run under the default libtest thread stack in a local debug build:
thread 'cli::tests::test_cli_parse_world_new_and_stats' has overflowed its stack
fatal runtime error: stack overflow, aborting
Evidence (2026-11-02, queue worker lane D, task 5655)
- Reproduced on the laptop in two independent worktrees:
~/git/fleet/5655(branch queue/5655-3144-new-subcommand) and~/git/fleet/5215(an unrelated branch state) —cargo test --manifest-path pkgs/id/Cargo.toml --no-default-features --features web --lib test_cli_parse_world_new_and_stats. The 5215 reproduction shows it is pre-existing, not caused by the task 5655 change. - Neighboring parse tests for issue id(find/search/show/peek): a zero count is accepted everywhere — '--first 0'/'--last 0' report 'no matches found' for queries that do match, and 'peek --lines 0' renders a preview with no content lines #3059 in the same module already wrap their bodies in
std::thread::Builder::new().stack_size(8 * 1024 * 1024)for exactly this reason (deep clap command-tree build/parse recursion vs the 2MiB test thread stack);test_cli_parse_world_new_and_statscallsCli::parse_fromdirectly and never got the workaround. The new task 5655 parse tests needed the same treatment. - Because the overflow aborts the process (SIGABRT), one overflowing test hides the results of every other test in the same filtered run.
Acceptance
test_cli_parse_world_new_and_stats(and any other direct-parse tests in the module with the same exposure) runs under a big-stack thread, following the existing id(find/search/show/peek): a zero count is accepted everywhere — '--first 0'/'--last 0' report 'no matches found' for queries that do match, and 'peek --lines 0' renders a preview with no content lines #3059 pattern in pkgs/id/src/cli.rs, OR the parse path's stack depth is reduced.cargo test --lib cli::completes locally in a debug build without a stack-overflow abort.
Acceptance criteria
cargo test -p id --lib cli::tests::test_cli_parse_world_new_and_statscompletes under the default libtest thread stack in a local debug build — no stack-overflow abort of the lib test binary.- The fix follows the existing spawned-thread pattern (id(find/search/show/peek): a zero count is accepted everywhere — '--first 0'/'--last 0' report 'no matches found' for queries that do match, and 'peek --lines 0' renders a preview with no content lines #3059,
pkgs/id/src/cli.rs) or demonstrably reduces the parse path's stack depth; the test's assertions/coverage are unchanged in intent. - The full
cargo test -p id --librun no longer aborts at this test.
Metadata
Metadata
Assignees
Labels
Package/app: id (pkgs/ or apps/ in this repo)Small: expected under 2 hours of workSomething isn't working (prefixed form of the classic bug label)Intake review done: acceptance criteria, links, and normalized labels addedOrdinary priority (the default)Queue task is parked (waiting on CI, time, or an event)Filed or worked by the queue/worker pilotDeliberately paused with a recorded resume conditionQueue packet kind: verify, reproduce, and route this itemQueue worker lifecycle state
Activity
dezren39 commentedon Nov 2, 2026
Second data point (2026-11-02, task 5515 verification): also stack-overflows and aborts the lib test binary under the default libtest stack on the laptop, in a run at PR #4288's head — after every world_doctor test itself had passed. Same fix pattern applies: big-stack thread like the #3059 tests.
dezren39 commentedon Nov 2, 2026
Intake review
🤖 Agent note · filed
pkgs/id/src/cli.rs; pattern reference issue id(find/search/show/peek): a zero count is accepted everywhere — '--first 0'/'--last 0' report 'no matches found' for queries that do match, and 'peek --lines 0' renders a preview with no content lines #3059Related: issue #3059 (existing spawned-thread pattern in the same file).
Notes: Still live — independently re-confirmed 2026-11-02T12:20Z by a queue lane: the full id lib test binary aborts on this pre-existing stack overflow on binaries without other changes. It blocks trusting full-suite local tallies, which is why priority is normal rather than low.
Risks: Low; test-harness change. Do not weaken the test's assertions to make it fit.
Suggested approach: Run the test body on a spawned thread with an explicit large stack, following the #3059 pattern already in
pkgs/id/src/cli.rs.dezren39 commentedon Nov 3, 2026
🤖 Agent note · evidence added
worldtest filter run aborted before completingmainat df05ea4 (detached worktree, no local changes),cargo test --manifest-path pkgs/id/Cargo.toml test_cli_parse_world_boot_windowreproduces the overflow (rc=101, SIGABRT, "has overflowed its stack"). A second test in the same family,cli::tests::source_only_mode_is_opt_in_and_requires_world_mode, overflowed the same way during acargo test worldrun, so the abort hides the whole lib binary's results for that filter too — two more test names for the fix's scope beyondtest_cli_parse_world_new_and_stats.developing-today commentedon Nov 3, 2026
agent-note:v1
state: triaged (coverage pass)
Coverage pass 2026-11-03: reviewed in the fleet-wide per-issue pass (drift / overlap / already-handled / stale / blockers / ordering). Verdict: still live; queued in repo-health-code-pilot as triage at priority 40 (priority/normal). If this is already handled at current main, the triage closes it with evidence; if it needs splitting, the triage files the split.
Found via: coverage pass 2026-11-03
dezren39 commentedon Nov 3, 2026
agent-note:v1
state: picked up (task 8383, triage)
Agent: repo-worker-code (openchamber scheduled lane 335a5d1f-bfc1-4831-99ea-850c8939a727)
Task: triage at current main — verify the stack overflow still reproduces or is already handled, then scope the fix or close with evidence.
dezren39 commentedon Nov 3, 2026
agent-note:v1
state: triaged (task 8383)
Agent: repo-worker-code — OpenChamber scheduled lane 335a5d1f-bfc1-4831-99ea-850c8939a727
Found via: current-main triage of queue task 8383
Revalidated open at current main (origin/main 3e363c9); no active PR for #4327. The defect is still present in source:
test_cli_parse_world_new_and_stats(cli.rs:4745) andtest_cli_parse_world_boot_window(4375) callCli::parse_fromon the default libtest thread; additional world parse tests from about line 4130 onward likewise parse directly. The existingparse_normalizedhelper (2582) uses a 32 MiB spawned thread, but the world tests do not use it.Fix path is scoped: run the exposed world CLI parse test bodies on a larger-stack thread, following the existing helper / #3059 pattern; extend to the exposed direct-parse world test family, not only the originally named test. Preserve assertions. Verify the named test, then
cargo test -p id --lib cli::and the full id lib suite. This lane's--features webattempt could not compile because clean main lacks generatedpkgs/id/web/dist; a world-only reproduction retry was started. Prior issue evidence (and task 6562) already reports clean-main reproductions for this family. No code fix or competing PR was created.dezren39 commentedon Nov 8, 2026
🤖 Agent note · handed off
opencode; handing off to the opencode claimant per worker instruction §1b (no direct work by this lane). Fresh check: issue id(test): test_cli_parse_world_new_and_stats stack-overflows under default libtest stack — abort hides all lib test results #4327 is OPEN, no hard-stop labels (held / user/owned / do-not-merge / do-not-auto-edit).