Skip to content

openclaw ACP adapter: load the standing-server credential — gateway launch wires no OPENCODE_SERVER_PASSWORD (#3997) #4615

Closed

Description

@dezren39

Finding (from PR review)

In the configured OpenClaw gateway, the ACP adapter (bin/opencode-acp-adapter.mjs) only authenticates if OPENCODE_SERVER_PASSWORD happens to be inherited, but home/openclaw/default.nix neither supplies that variable nor installs a wrapper to load it. Codex (P1, PR #3997):

The standing server requires the password stored in ~/.local/state/opencode/service-prod.json: bin/openchamber-start.sh loads it explicitly, as does the dispatch client. Unlike the previous private-server ACP command, this adapter therefore sends unauthenticated session and event requests in the declared gateway environment, preventing session creation even after the API contract is corrected. Read the standing server's credential at runtime or explicitly wire it into the adapter's launch environment.

Evidence

Acceptance criteria

  • The adapter, as launched by the OpenClaw gateway config in home/openclaw/default.nix, authenticates to the standing server — either by loading the credential from ~/.local/state/opencode/service-prod.json at runtime (as bin/openchamber-start.sh and the dispatch client do) or by explicit environment wiring in the launch definition.
  • Verified against the gateway launch path, not only a hand-exported shell environment.
  • Or the finding is resolved by a documented decision on this issue.

Activity

  1. added
    task/triageQueue packet kind: verify, reproduce, and route this item
    priority/highImportant and time-sensitive
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 2, 2026
  2. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · filed

  3. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · triaged — CONFIRMED; scoped fix routed

  4. added
    status/triagedTriaged and routed (see agent note)
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 2, 2026
  5. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    agent-note:v1
    event: already_done
    task: 6523 (repo-health-code-pilot; worker repo-worker-code; OpenChamber scheduled lane 02cafe76-eafd-4d0b-aaa6-2b7a737d68dc)
    result: This duplicate triage was already completed by task 6517. Fresh state: issue #4615 remains OPEN/status:triaged; task 6517 is done with confirmed verdict; scoped fix task 6521 is queued. No additional code or duplicate fix task created.

  6. added
    work/assignedQueue worker lifecycle state
    queue/claimedQueue worker lifecycle state
    and removed
    status/triagedTriaged and routed (see agent note)
    on Nov 2, 2026
  7. 1 remaining item

  8. dezren39 commented on Nov 2, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · parked

  9. added
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    status/parkedDeliberately paused with a recorded resume condition
    queue/claimedQueue worker lifecycle state
    and removed
    queue/claimedQueue worker lifecycle state
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 2, 2026
  10. added a commit that references this issue on Nov 2, 2026
  11. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · done

    Resumed from the prior park on PR #4655 (head 70bbea5): re-verified fresh this shift — laptop node --test bin/opencode-acp-adapter.test.mjs 8/8 pass at that head (including the new gateway-launch-path, auth-file precedence, and malformed-file tests, all with synthetic fixtures; no credential value read or printed), Codex review completed on 70bbea5 with no findings, diff matches the packet intent (runtime-load of ~/.local/state/opencode/service-prod.json, env var takes precedence, nothing baked into tracked config). The sole Actions check (metered-provider guard) remained QUEUED in the repo-wide Actions stall, so the merge proceeded on the verified evidence per the standing merge authority. PR #4655 MERGED (merge commit 16e8e34); issue #4615 closed by the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority/highImportant and time-sensitivesource/pr-comment-reviewFiled by the pr-comment-review jobtask/triageQueue packet kind: verify, reproduce, and route this item

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions