Skip to content

CI policy PR checks are missing workflow triggers #5149

Open

Description

@dezren39

Finding

The documented CI merge policy and the nix ci workflow triggers disagree:

  • .github/ci-policy.md says the basic: proxy port fallbacks check is the PR-tier merge requirement and says the workflow runs on merge-group events.
  • .github/workflows/nix-ci.yml currently declares only push to main, schedule, and workflow_dispatch; it has no pull_request or merge_group trigger.
  • On PR fix(aggregator): validate charges producer CLI args (#3333) #5145, gh pr checks showed only CodeRabbit as skipping, and gh run list found no workflow runs for the PR branch.

Expected

Reconcile the workflow triggers and policy so the documented required basic check runs for pull requests and merge-queue groups, or update the policy and branch rules to match the intended coverage. Verify the actual PR and merge-group check events.

Evidence observed 2026-11-03 while validating #3333.

Acceptance criteria

  • .github/workflows/nix-ci.yml triggers and .github/ci-policy.md agree: the documented PR-tier required check (basic: proxy port fallbacks) runs on pull_request and merge_group events, or the policy and branch rules are updated to the intended coverage with the rationale recorded on this issue.
  • A test PR shows the basic check actually running (not only CodeRabbit skipping).
  • A merge-group run is verified to produce the check before this closes.

Activity

  1. dezren39 commented on Nov 3, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · dedup (design-architect pass 46, 2026-11-03)

    This is the same finding as #4940 (open, priority/high, queue/queued): .github/workflows/nix-ci.yml has no pull_request or merge_group trigger, so the documented required PR-tier check basic: proxy port fallbacks never runs on a PR. #4932 was closed as superseded by #4940 earlier today.

    Recommend closing this as a duplicate of #4940 and keeping the fix there — its acceptance already covers the pull_request trigger, the merge_group trigger (or a ci-policy correction), and verification on a real PR. No separate fix track needed.

  2. added
    kind/ciCI/CD pipelines, workflows, and build automation
    priority/highImportant and time-sensitive
    effort/sSmall: expected under 2 hours of work
    area/ciCI/CD pipelines, workflows, and build automation (area)
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 4, 2026
  3. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    Intake review

    🤖 Fleet monitor intake pass, 2026-11-03 run.

  4. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/triageQueue packet kind: verify, reproduce, and route this item
    on Nov 4, 2026
  5. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    Agent note — task 9462 handed off to opencode execution lane

    • Lane: code-v (repo-worker-code), claimed 2026-11-04T12:34Z
    • Verified fresh: issue CI policy PR checks are missing workflow triggers #5149 OPEN, no hard-stop labels
    • Execution-lane assignment (repo-queue lane task 9462): opencode
    • Per worker instruction §1b, this lane does not work the task directly and creates no worktree. The laptop opencode-claimant launches a session bound to task 9462 to drive it to a terminal state.
    • Checkpointed as handed_off. If the claimant has not launched by lease expiry, task 9462 returns to the queue.
  6. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    Agent note — task 9462 handed off to opencode claimant (lane code-l)

    • Lane: code-l claimed task 9462 (triage of CI policy PR checks are missing workflow triggers #5149); execution-lane assignment returned opencode, so this worker does not work it directly.
    • Fresh check 2026-11-04T14:05Z: CI policy PR checks are missing workflow triggers #5149 OPEN, no hard-stop labels (labels at claim: kind/ci, task/triage, status/needs-triage, priority/high, queue/queued, area/ci, effort/s).
    • Action: task 9462 checkpointed handed_off and parked 1200s for the laptop opencode claimant to bind and launch its session. If unbound by lease/park expiry, the task returns to the queue.
  7. removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 4, 2026
  8. 106 remaining items

  9. added
    work/assignedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 7, 2026
  10. developing-today commented on Nov 7, 2026

    @developing-today
    Contributor

    Progress from repo-worker-code-n: claimed: triage CI policy PR checks missing workflow triggers; revalidating against current workflow files on main

  11. developing-today commented on Nov 7, 2026

    @developing-today
    Contributor

    Released by repo-worker-code-n (outcome: free). No work needed: fix already landed (PR #6752 merged 0de43de), criteria 1-2 verified fresh by lanes code-z/code-o tonight, and criterion 3 (verified merge-group run) was escalated to Drew with full substance by lane code-c at 2026-11-07T04:14Z (user/escalated stands — main has no merge queue). Lane code-n verified the comment chain fresh and releases without changes; remainder is Drew's decision only.

  12. added
    queue/queuedHas a queued task in the Supabase agent queue
    and removed
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    on Nov 7, 2026
  13. developing-today commented on Nov 7, 2026

    @developing-today
    Contributor

    Picked up by repo-worker-code-z — working this now. (Fleet queue fallback mode: the queue backend is down, so this issue's comments carry the claim. The claim stays live while repo-worker-code-z posts progress markers; after 30 minutes of silence any other worker may pick this up.)

  14. added
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 7, 2026
  15. developing-today commented on Nov 7, 2026

    @developing-today
    Contributor

    Released by repo-worker-code-z (outcome: free). No work needed (fallback, lane code-z): fix landed via PR #6752 (merged 0de43de); criteria 1-2 verified tonight by lanes code-z/code-o; criterion 3 escalated to Drew with full substance by lane code-c 2026-11-07T04:28Z (user/escalated stands — main has no merge queue). This claim was the known fallback re-claim race; released without changes. Remainder is Drew's decision only.

  16. added
    queue/queuedHas a queued task in the Supabase agent queue
    and removed
    queue/claimedQueue worker lifecycle state
    work/assignedQueue worker lifecycle state
    on Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/ciCI/CD pipelines, workflows, and build automation (area)effort/sSmall: expected under 2 hours of workkind/ciCI/CD pipelines, workflows, and build automationmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitivequeue/queuedHas a queued task in the Supabase agent queuestatus/triagedTriaged and routed (see agent note)task/triageQueue packet kind: verify, reproduce, and route this itemuser/escalatedQueue or user escalation state

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions