Skip to content

pm-stack(aggregator): typecheck red on main — src/item-history.ts uses GhKind without importing it from model.ts #5247

Closed

Description

@dezren39

Problem

bunx tsc --noEmit in pm-stack/aggregator fails on current main (verified at 6a1a351, clean worktree) with a second error alongside the one tracked in #5043:

src/item-history.ts(58,10): error TS2304: Cannot find name 'GhKind'.

GhKind is defined at pm-stack/aggregator/src/model.ts:24 (export type GhKind = "issue" | "pr") and used at src/item-history.ts:58 (kind?: GhKind;) without an import. Recent item-history commits (53635b5 for #5172, 8ea49db / a06bc4a for #3981) touched this file.

Evidence

Acceptance

Filed by the repo queue worker (lane code-m, task 8672) per the file-the-issue rule; the fix itself is out of scope for task 8672 / #5043, whose packet covers only the overview.test.ts fixture.

Acceptance criteria

Activity

  1. added
    kind/ciCI/CD pipelines, workflows, and build automation
    priority/highImportant and time-sensitive
    app/pm-stackpm-stack (Pad/Grist) in developing-today/code
    on Nov 4, 2026
  2. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    main-ci watch — new main failure for this workflow (fresh round, post-fix head)

    Reusing this open issue #5247, which already tracks this exact failure: the run's Typecheck step (bunx tsc --noEmit) fails with only src/item-history.ts(58,10): error TS2304: Cannot find name 'GhKind' — verified in the run's failed log; the TS2741 conflicts error from the previous track is gone. No duplicate issue filed, per the trigger dedupe rule.

    Fresh round note: the previous main-ci track for this workflow, issue #5043, was verified CLOSED at 2026-11-04T02:29:21Z (fix PR #5248 merged as 33bdcb5), and run 41761070921 was created 2026-11-04T02:29:23Z on that post-fix head — so this is a fresh round, tracked here on #5247 instead of a new duplicate. The run completed late (updated 2026-11-04T03:47:10Z) and was caught by the failure-filtered list. This issue had no queue task (the worker that filed it noted the fix was out of scope for task 8672), so the trigger enqueues a fix task for it now.

    Filed by main-ci-failure-fix-trigger (fleet). One fix track per failing workflow; duplicates are suppressed until this issue closes.

    🤖 Agent note · filed

  3. added
    queue/queuedHas a queued task in the Supabase agent queue
    task/small-fixQueue packet kind: bounded fix with reproduction and targeted tests
    source/ci-watchFiled by the main-ci-failure-fix-trigger (fleet CI watch)
    effort/xsTrivial: expected under 30 minutes of work
    meta/enrichedIntake review done: acceptance criteria, links, and normalized labels added
    on Nov 4, 2026
  4. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    Intake review

    🤖 Fleet monitor intake pass, 2026-11-03 run.

  5. added
    work/assignedQueue worker lifecycle state
    and removed
    queue/queuedHas a queued task in the Supabase agent queue
    on Nov 4, 2026
  6. 19 remaining items

  7. added
    queue/claimedQueue worker lifecycle state
    and removed
    queue/claimedQueue worker lifecycle state
    status/parkedDeliberately paused with a recorded resume condition
    queue/parkedQueue task is parked (waiting on CI, time, or an event)
    on Nov 4, 2026
  8. dezren39 commented on Nov 5, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

  9. dezren39 commented on Nov 5, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · handed off

  10. dezren39 commented on Nov 5, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · picked up

  11. dezren39 commented on Nov 5, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · done

    • Agent: repo queue worker (repo-worker-code, lane 8ac61616-3815-4e7b-b33d-840a3829154a)
    • Session / ID: queue task 9187
    • Outcome: reconciled as already_done; PR fix(aggregator): import GhKind for item history #5330 is MERGED at 145b8fb7c88a477cd00d49200a6afd61f7eda19a, and current main contains the GhKind type-only import.
    • CI: latest available main workflow run 41838039322 is red on 9 other test failures; Typecheck was skipped. The exact GhKind error is no longer present, and the prior task checkpoint records bunx tsc --noEmit passing on the branch.
    • Next: no code follow-up in this task scope; remaining suite failures are separate work.
  12. dezren39 commented on Nov 7, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · already_done — closed by coverage audit (deep run 2026-11-07)

    Verified fresh twice this run:

    • PR fix(aggregator): import GhKind for item history #5330 "fix(aggregator): import GhKind for item history" is MERGED (2026-11-05T01:54:24Z, read via gh pr view and gh api).
    • Current main pm-stack/aggregator/src/item-history.ts:43 reads import type { GhKind, GhState, ProjectPoolItem, RefKey } from "./model.ts"; — the TS2304 this issue filed is gone (read via gh api contents).
    • Lane task 9187 already reconciled this as already_done on 2026-11-05 but the issue was never closed.

    Closing as completed — the fix landed and acceptance (typecheck error eliminated at its cited site) is verified on main.

  13. dezren39 commented on Nov 7, 2026

    @dezren39
    MemberAuthor

    Coverage audit DELTA 2026-11-07 — closing as already_done (verified).

    • The fix for this issue landed in PR fix(aggregator): import GhKind for item history #5330 (fix(aggregator): import GhKind for item history), MERGED 2026-11-05T01:54:24Z at merge commit 145b8fb — verified twice via gh pr view this run. The PR carried no closing reference, so the issue stayed open.
    • Current main verified twice via the GitHub contents API this run: pm-stack/aggregator/src/item-history.ts line 43 reads import type { GhKind, GhState, ProjectPoolItem, RefKey } from "./model.ts"; and GhKind is used at line 58 — the exact TS2304 error this issue tracks is gone from the source.
    • Queue task 9187 already reconciled this as already_done on 2026-11-05 (agent note on this issue) after recording bunx tsc --noEmit passing on the fix branch; no live task remains and no follow-up is owed in this issue's scope (the other red main-suite failures are tracked separately).

    Closing on that evidence per the coverage-audit already_done rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

app/pm-stackpm-stack (Pad/Grist) in developing-today/codeeffort/xsTrivial: expected under 30 minutes of workkind/ciCI/CD pipelines, workflows, and build automationmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitivesource/ci-watchFiled by the main-ci-failure-fix-trigger (fleet CI watch)task/small-fixQueue packet kind: bounded fix with reproduction and targeted tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions