Repository navigation
Closed
Labels
app/pm-stackpm-stack (Pad/Grist) in developing-today/codepm-stack (Pad/Grist) in developing-today/codeeffort/xsTrivial: expected under 30 minutes of workTrivial: expected under 30 minutes of workkind/ciCI/CD pipelines, workflows, and build automationCI/CD pipelines, workflows, and build automationmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitiveImportant and time-sensitivesource/ci-watchFiled by the main-ci-failure-fix-trigger (fleet CI watch)Filed by the main-ci-failure-fix-trigger (fleet CI watch)task/small-fixQueue packet kind: bounded fix with reproduction and targeted testsQueue packet kind: bounded fix with reproduction and targeted tests
Description
Problem
bunx tsc --noEmit in pm-stack/aggregator fails on current main (verified at 6a1a351, clean worktree) with a second error alongside the one tracked in #5043:
src/item-history.ts(58,10): error TS2304: Cannot find name 'GhKind'.
GhKind is defined at pm-stack/aggregator/src/model.ts:24 (export type GhKind = "issue" | "pr") and used at src/item-history.ts:58 (kind?: GhKind;) without an import. Recent item-history commits (53635b5 for #5172, 8ea49db / a06bc4a for #3981) touched this file.
Evidence
- Found by queue task 8672 (lane code-m) while fixing pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032) #5043: before/after
bunx tsc --noEmitruns at origin/main 6a1a351. After the pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032) #5043 fixture fix, this is the only remaining tsc error;bun testis green (1515 pass / 0 fail). - The pm-aggregator-tests workflow runs
bunx tsc --noEmit, so main CI stays red until this lands even after pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032) #5043 is fixed.
Acceptance
-
src/item-history.tsimportsGhKindfrom./model.ts(type-only import, matching the file's existing import style) -
bunx tsc --noEmitin pm-stack/aggregator exits 0 (with pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032) #5043 also landed) -
bun testin pm-stack/aggregator still passes
Filed by the repo queue worker (lane code-m, task 8672) per the file-the-issue rule; the fix itself is out of scope for task 8672 / #5043, whose packet covers only the overview.test.ts fixture.
Acceptance criteria
src/item-history.tsimportsGhKindfrom./model.tsas a type-only import, matching the file's existing import style.bunx tsc --noEmitinpm-stack/aggregatorexits 0 (with pm-stack(aggregator): typecheck red on main — test/overview.test.ts HealthView fixture missing the new required conflicts field (from #1282 / PR #5032) #5043 also landed).bun testinpm-stack/aggregatorstill passes.
Metadata
Metadata
Assignees
Labels
app/pm-stackpm-stack (Pad/Grist) in developing-today/codepm-stack (Pad/Grist) in developing-today/codeeffort/xsTrivial: expected under 30 minutes of workTrivial: expected under 30 minutes of workkind/ciCI/CD pipelines, workflows, and build automationCI/CD pipelines, workflows, and build automationmeta/enrichedIntake review done: acceptance criteria, links, and normalized labels addedIntake review done: acceptance criteria, links, and normalized labels addedpriority/highImportant and time-sensitiveImportant and time-sensitivesource/ci-watchFiled by the main-ci-failure-fix-trigger (fleet CI watch)Filed by the main-ci-failure-fix-trigger (fleet CI watch)task/small-fixQueue packet kind: bounded fix with reproduction and targeted testsQueue packet kind: bounded fix with reproduction and targeted tests
Activity
dezren39 commentedon Nov 4, 2026
main-ci watch — new main failure for this workflow (fresh round, post-fix head)
Reusing this open issue #5247, which already tracks this exact failure: the run's Typecheck step (
bunx tsc --noEmit) fails with onlysrc/item-history.ts(58,10): error TS2304: Cannot find name 'GhKind'— verified in the run's failed log; the TS2741conflictserror from the previous track is gone. No duplicate issue filed, per the trigger dedupe rule.Fresh round note: the previous main-ci track for this workflow, issue #5043, was verified CLOSED at 2026-11-04T02:29:21Z (fix PR #5248 merged as 33bdcb5), and run 41761070921 was created 2026-11-04T02:29:23Z on that post-fix head — so this is a fresh round, tracked here on #5247 instead of a new duplicate. The run completed late (updated 2026-11-04T03:47:10Z) and was caught by the failure-filtered list. This issue had no queue task (the worker that filed it noted the fix was out of scope for task 8672), so the trigger enqueues a fix task for it now.
Filed by main-ci-failure-fix-trigger (fleet). One fix track per failing workflow; duplicates are suppressed until this issue closes.
🤖 Agent note · filed
dezren39 commentedon Nov 4, 2026
Intake review
GhKindimport — this issue is still live.pm-aggregator-tests) stays red on main until this lands.bunx tsc --noEmitandbun testinpm-stack/aggregator(CI), merge.🤖 Fleet monitor intake pass, 2026-11-03 run.
19 remaining items
dezren39 commentedon Nov 5, 2026
🤖 Agent note · handed off
dezren39 commentedon Nov 5, 2026
🤖 Agent note · handed off
dezren39 commentedon Nov 5, 2026
🤖 Agent note · picked up
repo-worker-code, lane8ac61616-3815-4e7b-b33d-840a3829154a)145b8fb7c88a477cd00d49200a6afd61f7eda19a.dezren39 commentedon Nov 5, 2026
🤖 Agent note · done
repo-worker-code, lane8ac61616-3815-4e7b-b33d-840a3829154a)already_done; PR fix(aggregator): import GhKind for item history #5330 is MERGED at145b8fb7c88a477cd00d49200a6afd61f7eda19a, and current main contains theGhKindtype-only import.bunx tsc --noEmitpassing on the branch.dezren39 commentedon Nov 7, 2026
🤖 Agent note · already_done — closed by coverage audit (deep run 2026-11-07)
Verified fresh twice this run:
gh pr viewandgh api).pm-stack/aggregator/src/item-history.ts:43readsimport type { GhKind, GhState, ProjectPoolItem, RefKey } from "./model.ts";— the TS2304 this issue filed is gone (read viagh apicontents).Closing as completed — the fix landed and acceptance (typecheck error eliminated at its cited site) is verified on main.
dezren39 commentedon Nov 7, 2026
Coverage audit DELTA 2026-11-07 — closing as already_done (verified).
gh pr viewthis run. The PR carried no closing reference, so the issue stayed open.pm-stack/aggregator/src/item-history.tsline 43 readsimport type { GhKind, GhState, ProjectPoolItem, RefKey } from "./model.ts";andGhKindis used at line 58 — the exact TS2304 error this issue tracks is gone from the source.already_doneon 2026-11-05 (agent note on this issue) after recordingbunx tsc --noEmitpassing on the fix branch; no live task remains and no follow-up is owed in this issue's scope (the other red main-suite failures are tracked separately).Closing on that evidence per the coverage-audit already_done rule.