Skip to content

fleet(queue): fleet queue --version / repo-queue --version silently ignore trailing arguments #5603

Closed

Description

@dezren39

fleet(queue): fleet queue --version / repo-queue --version silently ignore trailing arguments

Summary

The queue domain's --version shortcut in the fleet multicall binary checks only the first argument and returns success no matter what follows it:

So fleet queue --version --bogus reports success for a command line that contains an unrecognized flag, and the argv0 form repo-queue --version junk does the same.

Verified this run (2026-11-04, laptop, binary rebuilt from main 18f0aa1a6)

$ fleet queue --version            → "fleet 0.1.0", exit 0   (control, correct)
$ fleet queue --version junkextra  → "fleet 0.1.0", exit 0   (trailing arg silently ignored)
$ fleet queue --version --bogus    → "fleet 0.1.0", exit 0   (unrecognized flag silently ignored)
$ fleet queue -V junk              → "fleet 0.1.0", exit 0   (same for -V)
$ repo-queue --version junk        → "repo-queue 0.1.0", exit 0  (argv0 alias route, same arm)
$ fleet --version junk             → usage error, exit 2     (control: root arm, fixed by #5572)

Why it matters

Acceptance criteria

  • fleet queue --version <anything-else> and fleet queue -V <anything-else> (including via the repo-queue argv0 alias) exit 2 with a usage error naming the unexpected argument, before printing the version — mirroring run_root's reject_extra_args behavior for the root built-ins.
  • Bare fleet queue --version / -V and repo-queue --version still print the version and exit 0.
  • A pinning test covers the queue-domain version arm with and without a trailing argument, alongside the existing root_builtins_reject_trailing_arguments test in main.rs.

Evidence

Activity

  1. added
    kind/bugSomething isn't working (prefixed form of the classic bug label)
    task/small-fixQueue packet kind: bounded fix with reproduction and targeted tests
    source/creatorFiled by the new-issue-creator job
    on Nov 4, 2026
  2. developing-today commented on Nov 4, 2026

    @developing-today
    Contributor
  3. added
    priority/normalOrdinary priority (the default)
    work/self-assignedAn agent grabbed this item directly, outside the queue
    app/fleetpkgs/fleet multicall binary + platform crates
    on Nov 4, 2026
  4. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · state: filed

    • Agent: new-issue-creator job (new-issue-creator-code-a)
    • Session / ID: cron new-issue-creator-code-a run 2026-11-04 11:35 CST
    • Found via: filed this run
    • Task: Filed this issue after verifying on the laptop (binary rebuilt from main 18f0aa1): fleet queue --version junkextra / --bogus and repo-queue --version junk all print the version and exit 0, while the root control fleet --version junk exits 2. Guarded self-solve this run (trivial, clearly scoped, low-risk): the queue-domain version arm in run_domain gets the same arity guard the root built-ins got in fleet: root built-ins (version / capabilities / --version) silently ignore trailing arguments #5572, plus a pinning test.
    • Expectation: effort xs; done = PR merged with the guard + test, fixed binary re-probed (trailing-arg forms exit 2, bare forms exit 0).
    • Links: branch creator-a/5603-queue-version-args (incoming)
  5. dezren39 commented on Nov 4, 2026

    @dezren39
    MemberAuthor

    🤖 Agent note · state: done

    • Agent: new-issue-creator job (new-issue-creator-code-a)
    • Session / ID: cron new-issue-creator-code-a run 2026-11-04 11:35 CST
    • Found via: filed this run
    • Task: Self-solved (guarded, trivial): PR fix(fleet): queue-domain --version rejects trailing arguments (#5603) #5605 squash-merged as 7912457 — the queue-domain --version/-V arm in run_domain now rejects a trailing argument with a usage error naming it (exit 2), and the new pinning test queue_domain_version_rejects_trailing_arguments covers both flags with and without a trailing argument.
    • Expectation: done — cargo test -p fleet green on the laptop (5 passed); fixed binary re-probed: trailing-arg forms (fleet queue --version junkextra, -V --bogus, repo-queue argv0 --version junk) exit 2, bare forms exit 0.
    • Links: PR fix(fleet): queue-domain --version rejects trailing arguments (#5603) #5605 (merged), branch creator-a/5603-queue-version-args (deleted on merge)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    app/fleetpkgs/fleet multicall binary + platform crateskind/bugSomething isn't working (prefixed form of the classic bug label)priority/normalOrdinary priority (the default)source/creatorFiled by the new-issue-creator jobstatus:donetask/small-fixQueue packet kind: bounded fix with reproduction and targeted tests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions