Skip to content

test(id): F11.9 bytes-per-frame baseline for checked-in examples (#542) - #1429

Merged
dezren39 merged 2 commits into
mainfrom
queue/1313-542-bytes-per-frame
Oct 27, 2026
Merged

dezren39 merged 2 commits into
mainfrom
queue/1313-542-bytes-per-frame

Conversation

@dezren39

@dezren39 dezren39 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Closes #542

F11.9 bytes-per-frame baseline: adds a rerunnable sandbox measurement test and commits the baseline table F12.11 delta frames must beat.

Measurement (pkgs/id/src/sandbox.rs, test bytes_per_frame_baseline_for_checked_in_examples): instantiates each of the 7 checked-in example wasms in the Sandbox with seed 7 and records the full-screen frame byte length at 80x24 and 200x60 via layout_at (which falls back to view() for guests without plaza_layout; the test asserts that fallback invariant and the printed table marks it).

Table (doc/2026-10-27T00-00-00Z_baseline_bytes_per_frame.md, measured at 37418e5):

example plaza_layout bytes @ 80x24 bytes @ 200x60
lounge yes 29 29
roc-chat yes 24 24
roc-counter yes 7 7
roc-grid yes 383 383
roc-screen yes 179 179
territory yes 1010 1010
tic-tac-toe yes 25 25

All 7 export plaza_layout (no fallback used); at rest each frame is the same length at both viewports — recorded in the doc as a baseline datum. Baseline is guest frame bytes at the sandbox boundary; presenter wire encodings (surface JSON / ANSI) are explicitly out of scope in the doc.

Tests (laptop, pkgs/id):

  • cargo test --lib bytes_per_frame_baseline -- --nocapture — pass, table printed
  • cargo test --lib sandbox:: — 30 passed
  • cargo test --lib world_fixture — 15 passed

Rerun: cd pkgs/id && cargo test --lib bytes_per_frame_baseline -- --nocapture

Queue task 1313.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 27, 2026 15:25
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9bce2d39-8228-4f7c-b2a7-88d20265bba6
Commits

Reviewing files that changed from the base of the PR and between a3fd099 and 08b8882.

Files selected for processing: 2
  • doc/2026-10-27T00-00-00Z_baseline_bytes_per_frame.md
  • pkgs/id/src/sandbox.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T15:33:22.979111Z 08b8882 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id(world): F11.9 bytes-per-frame baseline table

1 participant