Repository navigation
test(id): F11.9 bytes-per-frame baseline for checked-in examples (#542) - #1429
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Closes #542
F11.9 bytes-per-frame baseline: adds a rerunnable sandbox measurement test and commits the baseline table F12.11 delta frames must beat.
Measurement (
pkgs/id/src/sandbox.rs, testbytes_per_frame_baseline_for_checked_in_examples): instantiates each of the 7 checked-in example wasms in the Sandbox with seed 7 and records the full-screen frame byte length at 80x24 and 200x60 vialayout_at(which falls back toview()for guests withoutplaza_layout; the test asserts that fallback invariant and the printed table marks it).Table (
doc/2026-10-27T00-00-00Z_baseline_bytes_per_frame.md, measured at 37418e5):All 7 export
plaza_layout(no fallback used); at rest each frame is the same length at both viewports — recorded in the doc as a baseline datum. Baseline is guest frame bytes at the sandbox boundary; presenter wire encodings (surface JSON / ANSI) are explicitly out of scope in the doc.Tests (laptop, pkgs/id):
cargo test --lib bytes_per_frame_baseline -- --nocapture— pass, table printedcargo test --lib sandbox::— 30 passedcargo test --lib world_fixture— 15 passedRerun:
cd pkgs/id && cargo test --lib bytes_per_frame_baseline -- --nocaptureQueue task 1313.
Need help on this PR? Tag
@codesmith-botwith what you need.